Change sidebar file while changing file in slideshow by gary-kim · Pull Request #394 · nextcloud/viewer

gary-kim · 2020-02-10T13:12:47Z

Closes#380

Change sidebar file when changing file in slideshow.
Also made it so that the sidebar gets opened again when opening the viewer so that the sidebar does not end up under the modal.

Signed-off-by: Gary Kim gary@garykim.dev

skjnldsv · 2020-02-24T14:31:42Z

Could you add tests please? :)

cypress · 2020-02-25T04:00:19Z

Test summary

135 • 0 • 0 • 0

Run details


Project	viewer
Status	Passed
Commit	`ad5cd2e`ℹ️
Started	Feb 25, 2020 2:27 PM
Ended	Feb 25, 2020 2:28 PM
Duration	01:51 💡
OS	Linux Ubuntu Linux - 18.04
Browser	Electron 78

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

gary-kim · 2020-02-25T05:24:37Z

Could you add tests please? :)

Tests added for both sidebar image changing and opening viewer with sidebar open.

skjnldsv · 2020-02-25T08:07:41Z

/backport to stable18

cypress · 2020-02-25T12:30:23Z

Test summary

134 • 0 • 0 • 0

Run details


Project	viewer
Status	Passed
Commit	`904a94c`
Started	Feb 25, 2020 12:27 PM
Ended	Feb 25, 2020 12:29 PM
Duration	01:38 💡
OS	Linux Ubuntu Linux - 18.04
Browser	Electron 78

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Signed-off-by: Gary Kim <gary@garykim.dev>

gary-kim · 2020-02-25T14:25:37Z

🤦‍♂️

skjnldsv · 2020-02-25T14:27:58Z

Yes, do no commit the screenshots ;)

skjnldsv · 2020-02-25T14:30:49Z

Great work :)
One question though, what is expected on the last step Opening the sidebar before the viewer? I don't see any relevant actions on the cypress run 🤔

gary-kim · 2020-02-25T14:47:18Z

One question though, what is expected on the last step Opening the sidebar before the viewer? I don't see any relevant actions on the cypress run thinking

Checking that the sidebar does not end up under the modal when the viewer is opened with the sidebar already being opened.

skjnldsv · 2020-02-25T15:25:03Z

Make sense :)

backportbot-nextcloud · 2020-02-25T15:25:36Z

The backport to stable18 failed. Please do this backport manually.

gary-kim · 2020-02-26T03:45:48Z

Backport in #405

skjnldsv · 2020-03-04T12:34:21Z

+ * Show sidebar if sidebar is already opened
+ */
+ changeSidebar() {
+ if (this.sidebarFile !== '') {


Eheh, this doesn't check against null or undefined.
Meaning if the sidebar is not available (no OCA.Files.Sidebar) it will still try to open :)
I'll fix in a secondary pr

…e-change Change sidebar file while changing file in slideshow

gary-kim added enhancement New feature or request 3. to review Waiting for reviews labels Feb 10, 2020

gary-kim added this to the Nextcloud 19 milestone Feb 10, 2020

gary-kim requested review from juliusknorr and skjnldsv February 10, 2020 13:12

gary-kim force-pushed the enh/380/change-sidebar-on-image-change branch 2 times, most recently from c726965 to b931e2eCompare February 11, 2020 13:20

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 24, 2020

gary-kim force-pushed the enh/380/change-sidebar-on-image-change branch 3 times, most recently from 784ac6b to 59803cbCompare February 25, 2020 03:54

gary-kim force-pushed the enh/380/change-sidebar-on-image-change branch 5 times, most recently from 3e1fdda to dc5c5f5Compare February 25, 2020 05:19

gary-kim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 25, 2020

skjnldsv requested changes Feb 25, 2020
View reviewed changes

Comment threadcypress/integration/sidebar.spec.js

backportbot-nextcloudBot added the backport-request Pending backport by the backport-bot label Feb 25, 2020

gary-kim force-pushed the enh/380/change-sidebar-on-image-change branch from dc5c5f5 to 904a94cCompare February 25, 2020 12:15

gary-kim requested a review from skjnldsv February 25, 2020 12:35

skjnldsv reviewed Feb 25, 2020
View reviewed changes

Comment threadcypress/integration/sidebar.spec.js

Change sidebar file while changing file in slideshow
6fc9760
Signed-off-by: Gary Kim <gary@garykim.dev>

gary-kim force-pushed the enh/380/change-sidebar-on-image-change branch from 904a94c to 6fc9760Compare February 25, 2020 14:24

skjnldsv approved these changes Feb 25, 2020
View reviewed changes

skjnldsv merged commit c54661f into masterFeb 25, 2020

skjnldsv deleted the enh/380/change-sidebar-on-image-change branch February 25, 2020 15:25

gary-kim mentioned this pull request Feb 26, 2020
[stable18] Change sidebar file while changing file in slideshow #405
Merged

gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews backport-request Pending backport by the backport-bot labels Feb 26, 2020

skjnldsv reviewed Mar 4, 2020
View reviewed changes

susnux pushed a commit that referenced this pull request May 16, 2026
Merge pull request#394from nextcloud/enh/380/change-sidebar-on-imag…
6916eb4
…e-change Change sidebar file while changing file in slideshow

susnux pushed a commit that referenced this pull request May 16, 2026
Merge pull request#394from nextcloud/enh/380/change-sidebar-on-imag…
fd68ae1
…e-change Change sidebar file while changing file in slideshow

susnux pushed a commit that referenced this pull request May 16, 2026
Merge pull request#394from nextcloud/enh/380/change-sidebar-on-imag…
e71d1d1
…e-change Change sidebar file while changing file in slideshow

susnux pushed a commit that referenced this pull request May 16, 2026
Merge pull request#394from nextcloud/enh/380/change-sidebar-on-imag…
397ddf4
…e-change Change sidebar file while changing file in slideshow

susnux pushed a commit that referenced this pull request May 16, 2026
Merge pull request#394from nextcloud/enh/380/change-sidebar-on-imag…
6f1003e
…e-change Change sidebar file while changing file in slideshow

susnux pushed a commit that referenced this pull request May 16, 2026
Merge pull request#394from nextcloud/enh/380/change-sidebar-on-imag…
d780b1f
…e-change Change sidebar file while changing file in slideshow

Uh oh!

Conversation

gary-kim commented Feb 10, 2020

Uh oh!

skjnldsv commented Feb 24, 2020

Uh oh!

cypressBot commented Feb 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test summary

Run details

Uh oh!

gary-kim commented Feb 25, 2020

Uh oh!

Uh oh!

skjnldsv commented Feb 25, 2020

Uh oh!

cypressBot commented Feb 25, 2020

Test summary

Run details

Uh oh!

Uh oh!

gary-kim commented Feb 25, 2020

Uh oh!

skjnldsv commented Feb 25, 2020

Uh oh!

skjnldsv commented Feb 25, 2020

Uh oh!

gary-kim commented Feb 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skjnldsv commented Feb 25, 2020

Uh oh!

backportbot-nextcloudBot commented Feb 25, 2020

Uh oh!

gary-kim commented Feb 26, 2020

Uh oh!

skjnldsvMar 4, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cypressBot commented Feb 25, 2020•
edited
Loading

gary-kim commented Feb 25, 2020•
edited
Loading