Uh oh!
There was an error while loading. Please reload this page.
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard | ||||||||||||||||||||||||||
skjnldsv
commented
Aug 24, 2020
Hey! Please add a test example as well :) |
MorrisJobke
commented
Sep 15, 2020
I tried this, but it only says "error while loading image.heic". 😢 |
skjnldsv
commented
Sep 15, 2020
Browser console logs? |
MorrisJobke
commented
Sep 15, 2020
Nothing suspicious. :/ |
skjnldsv
commented
Sep 15, 2020
I guess it's just nt supported 🤷 ? |
MorrisJobke
commented
Sep 15, 2020
Also this just uses the plain WebDAV endpoint and not the preview one. |
MorrisJobke
commented
Sep 15, 2020
Works for me and uses preview 🤷 https://filesamples.com/samples/image/heic/sample1.heic @MorrisJobke does your setup have heic previews properly enabled/configured? |
skjnldsv
commented
Sep 15, 2020
@steiny2k please rebase and add a cypress tests for displaying an heic image. |
MorrisJobke
commented
Sep 16, 2020
No. Do I need that? I just use the default configuration. And then it loads the file via WebDAV. |
skjnldsv
commented
Sep 16, 2020
you have a GET request to webdav? |
MorrisJobke
commented
Sep 16, 2020
Yes, multiple. one to each file of the folder on every slide change. So if there are 3 heic images in a folder and I click on one, then the viewer opens and all files are fetched. On the slideshow change to the next all 3 are fetched again and so on. |
Signed-off-by: Sebastian Steinmetz <462714+steiny2k@users.noreply.github.com>
Example file is from https://www.online-convert.com/file-format/heic and under CC-BY http://www.online-convert.com Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Sep 16, 2020
Rebased and added the tests 👍 |


Replaces PR #485. Rebased to master and that's it.
Signed-off-by: Sebastian Steinmetz 462714+steiny2k@users.noreply.github.com