Skip to content

Add heic image support - #577

Merged
skjnldsv merged 2 commits into
masterfrom
heic
Sep 16, 2020
Merged

Add heic image support#577
skjnldsv merged 2 commits into
masterfrom
heic

Conversation

@steiny2k

@steiny2ksteiny2k commented Aug 23, 2020

Copy link
Copy Markdown
Contributor

Replaces PR #485. Rebased to master and that's it.

Signed-off-by: Sebastian Steinmetz 462714+steiny2k@users.noreply.github.com

@cypress

cypressBot commented Aug 23, 2020

Copy link
Copy Markdown



Test summary

150100


Run details

Projectviewer
StatusFailed
Commit93ee967ℹ️
StartedAug 23, 2020 1:58 PM
EndedAug 23, 2020 2:00 PM
Duration01:53 💡
OSLinux Ubuntu Linux - 18.04
BrowserElectron 78

View run in Cypress Dashboard ➡️


Failures

cypress/integration/sidebar.spec.js Failed
1 Open the sidebar from the viewer and open viewer with sidebar already opened > Does not see a loading animation

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@skjnldsv

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added 2. developing Work in progress enhancement New feature or request labels Aug 24, 2020
@MorrisJobke

Copy link
Copy Markdown
Member

I tried this, but it only says "error while loading image.heic". 😢

@skjnldsv

Copy link
Copy Markdown
Member

I tried this, but it only says "error while loading image.heic".

Browser console logs?

@MorrisJobke

Copy link
Copy Markdown
Member

Browser console logs?

Nothing suspicious. :/

@skjnldsv

Copy link
Copy Markdown
Member

I guess it's just nt supported 🤷 ?
Can you open the file in a new tab?

@MorrisJobke

Copy link
Copy Markdown
Member

Also this just uses the plain WebDAV endpoint and not the preview one.

@MorrisJobke

Copy link
Copy Markdown
Member

Bildschirmfoto 2020-09-15 um 19 44 25

Actually there was something in the console :/

@skjnldsv

skjnldsv commented Sep 15, 2020

Copy link
Copy Markdown
Member

Works for me and uses preview 🤷

Capture d’écran_2020-09-15_22-50-00

https://filesamples.com/samples/image/heic/sample1.heic

@MorrisJobke does your setup have heic previews properly enabled/configured?

@skjnldsv

Copy link
Copy Markdown
Member

@steiny2k please rebase and add a cypress tests for displaying an heic image.
You can most likely just copy like https://github.com/nextcloud/viewer/blob/master/cypress/integration/image.png.spec.js

@MorrisJobke

Copy link
Copy Markdown
Member

@MorrisJobke does your setup have heic previews properly enabled/configured?

No. Do I need that? I just use the default configuration. And then it loads the file via WebDAV.

@skjnldsv

Copy link
Copy Markdown
Member

No. Do I need that? I just use the default configuration. And then it loads the file via WebDAV.

you have a GET request to webdav?

@MorrisJobke

Copy link
Copy Markdown
Member

you have a GET request to webdav?

Yes, multiple. one to each file of the folder on every slide change. So if there are 3 heic images in a folder and I click on one, then the viewer opens and all files are fetched. On the slideshow change to the next all 3 are fetched again and so on.

steiny2kand others added 2 commits September 16, 2020 10:28
Signed-off-by: Sebastian Steinmetz <462714+steiny2k@users.noreply.github.com>
Example file is from https://www.online-convert.com/file-format/heic and under CC-BY http://www.online-convert.com
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
Member

Rebased and added the tests 👍

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 16, 2020
@MorrisJobkeMorrisJobke added this to the Nextcloud 20 milestone Sep 16, 2020
@skjnldsv
skjnldsv merged commit 6f3b742 into masterSep 16, 2020
@skjnldsv
skjnldsv deleted the heic branch September 16, 2020 08:41
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2020
@MorrisJobkeMorrisJobke mentioned this pull request Sep 16, 2020
5 tasks
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@steiny2k@skjnldsv@MorrisJobke