Uh oh!
There was an error while loading. Please reload this page.
Fix tox env ordering issue - #1457
Merged
Merged
Conversation
- flake8 and docs depend on codegen - test depends on installers (for `install_local_wheel.py --driver nitclk`), not codegen - pkg depends on installers
Codecov Report
@@ Coverage Diff @@## master #1457 +/- ##
=======================================
Coverage 91.93% 91.93% =======================================
Files 20 20 Lines 3658 3658 =======================================
Hits 3363 3363 Misses 295 295
Continue to review full report at Codecov.
|
marcoskirsch
approved these changes
May 20, 2020
marcoskirsch
left a comment
Member
There was a problem hiding this comment.
If this allows us to run tox in parallel on CI, why wouldn't we want to do it?
sbethur
commented
May 29, 2020
ContributorAuthor
I don't see a reason why not. Trying it out in #1471. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Fix tox env ordering issue:
install_local_wheel.py --driver nitclk), not codegenList issues fixed by this Pull Request below, if any.
None
What testing has been done?
Ran
toxin serial and parallel modes and verified the ordering is correct.