Skip to content

Correct 1.2.0 changelog - #2074

Open
ni-jfitzger wants to merge 2 commits into
ni:masterfrom
ni-jfitzger:changelog-fix-python-3.8-details
Open

Correct 1.2.0 changelog#2074
ni-jfitzger wants to merge 2 commits into
ni:masterfrom
ni-jfitzger:changelog-fix-python-3.8-details

Conversation

@ni-jfitzger

Copy link
Copy Markdown
Collaborator
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Our CHANGELOG incorrectly stated that we added Python 3.8 support in both 1.1.4 and 1.2.0. In 1.2.0, we added the classifier to declare support on the PyPI page, because we neglected to do so in 1.1.4.

This change clarifies the 1.2.0 section of the CHANGELOG.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

@codecov-commenter

codecov-commenter commented Jan 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.35%. Comparing base (dd57eae) to head (fff98e8).
⚠️ Report is 72 commits behind head on master.

❌ Your project status has failed because the head coverage (82.35%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (dd57eae) and HEAD (fff98e8). Click for more details.

HEAD has 10 uploads less than BASE
FlagBASE (dd57eae)HEAD (fff98e8)
niscopeunittests43
nisesystemtests10
niswitchsystemtests10
nimodinstsystemtests10
nidmmsystemtests10
niscopesystemtests10
nifgensystemtests10
nidcpowersystemtests10
nitclksystemtests10
nidigitalsystemtests10
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #2074 +/- ##
==========================================
- Coverage 91.33% 82.35% -8.99% 
==========================================
Files 66 28 -38 Lines 16274 4001 -12273 ==========================================
- Hits 14864 3295 -11569 + Misses 1410 706 -704 
FlagCoverage Δ
codegenunittests84.95% <ø> (ø)
nidcpowersystemtests?
nidcpowerunittests89.53% <ø> (ø)
nidigitalsystemtests?
nidigitalunittests68.45% <ø> (ø)
nidmmsystemtests?
nifakeunittests87.24% <ø> (ø)
nifgensystemtests?
nimodinstsystemtests?
nimodinstunittests94.20% <ø> (ø)
niscopesystemtests?
niscopeunittests43.20% <ø> (ø)
nisesystemtests?
niswitchsystemtests?
nitclksystemtests?
nitclkunittests98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 42 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd57eae...fff98e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger

Copy link
Copy Markdown
CollaboratorAuthor

Do not merge until after the 1.4.9 release.

@ni-jfitzgerni-jfitzger left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG has changed, since this PR was created. I'll need to pull main and recreate the change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ni-jfitzger@codecov-commenter