Skip to content

Update the order and default values in nifake metadata - #2134

Open
rahulr-NI wants to merge 3 commits into
ni:masterfrom
rahulr-NI:MiscChangesToMatchAzDoExports
Open

Update the order and default values in nifake metadata #2134
rahulr-NI wants to merge 3 commits into
ni:masterfrom
rahulr-NI:MiscChangesToMatchAzDoExports

Conversation

@rahulr-NI

@rahulr-NIrahulr-NI commented Sep 24, 2025

Copy link
Copy Markdown

- [ ] I've updated CHANGELOG.md if applicable.

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR updates the nimi-python repository metadata files with those from NI's private repository, resolves ordering issues, and addresses default values.
It contains new APIs generated during codegen but not present in nimi-python.

What testing has been done?

Tox build is failing here as in gRPC, the abort api in generated codes is not implemented but the existing test cases are expecting it.

@rahulr-NIrahulr-NI changed the title Misc changes to match az do exports for nirfsg moduleMisc changes to match AzDo exports for nirfsg moduleSep 24, 2025
@codecov-commenter

codecov-commenter commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.72%. Comparing base (3432530) to head (d825349).

Files with missing linesPatch %Lines
generated/nifake/nifake/_grpc_stub_interpreter.py0.00%1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3432530) and HEAD (d825349). Click for more details.

HEAD has 10 uploads less than BASE
FlagBASE (3432530)HEAD (d825349)
nifgensystemtests10
nimodinstsystemtests10
nirfsgsystemtests10
nidcpowersystemtests10
nidmmsystemtests10
nitclksystemtests10
nisesystemtests10
nidigitalsystemtests10
niswitchsystemtests10
niscopesystemtests10
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #2134 +/- ##
==========================================
- Coverage 89.07% 81.72% -7.35% 
==========================================
Files 71 29 -42 Lines 18960 4116 -14844 ==========================================
- Hits 16889 3364 -13525 + Misses 2071 752 -1319 
FlagCoverage Δ
codegenunittests84.44% <ø> (ø)
nidcpowersystemtests?
nidcpowerunittests89.53% <ø> (ø)
nidigitalsystemtests?
nidigitalunittests68.44% <ø> (ø)
nidmmsystemtests?
nifakeunittests85.53% <50.00%> (+0.01%)⬆️
nifgensystemtests?
nimodinstsystemtests?
nimodinstunittests94.20% <ø> (ø)
nirfsgsystemtests?
niscopesystemtests?
niscopeunittests43.20% <ø> (ø)
nisesystemtests?
niswitchsystemtests?
nitclksystemtests?
nitclkunittests98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
generated/nifake/nifake/session.py77.55% <100.00%> (+0.04%)⬆️
generated/nifake/nifake/_grpc_stub_interpreter.py83.06% <0.00%> (ø)

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3432530...d825349. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NIrahulr-NI changed the title Misc changes to match AzDo exports for nirfsg moduleMisc changes to match metadatada version for nifakeSep 24, 2025
@rahulr-NIrahulr-NI changed the title Misc changes to match metadatada version for nifakeUpdate the order and default values in nifake metadata Sep 24, 2025
@rahulr-NI
rahulr-NI marked this pull request as ready for review September 24, 2025 06:19
'description': 'Aborts a previously initiated thingie.'
},
'included_in_proto': True,
'included_in_proto': False,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abort is such a common function that it's strange not to include in the example/fake/test metadata

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.. Thats why I did not modify any portion of metadata that being generated from AzDo. We will need to create some stories to issues to make the necessary changes to Match AzDo version of metadata generated from AzDo to version present in GitHub. Which also should include the necessary test cases.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rahulr-NI@codecov-commenter@marcoskirsch@rahur-NI