Skip to content

Make code-assert a test dependency - #198

Open
sirocchj wants to merge 1 commit into
nidi3:masterfrom
sirocchj:codeassert-test-scope
Open

Make code-assert a test dependency#198
sirocchj wants to merge 1 commit into
nidi3:masterfrom
sirocchj:codeassert-test-scope

Conversation

@sirocchj

Copy link
Copy Markdown

code-assert is using checkstyle:6.19 that pulls in commons-beanutils:1.9.2, which is subject to CVE-2019-10086 (see also here).

While this addresses the issue in code-assert, I believe this dependency should not be scoped to compile in graphviz-java to begin with, unless I am missing something.

@codecov-io

codecov-io commented Mar 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #198 (a0eeb74) into master (f0c1fdf) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #198 +/- ##
============================================
- Coverage 83.81% 83.66% -0.16% + Complexity 1279 1277 -2 
============================================
Files 109 109 Lines 3813 3813 Branches 385 385 ============================================
- Hits 3196 3190 -6 - Misses 402 408 +6 
Partials 215 215 
Impacted FilesCoverage ΔComplexity Δ
...n/java/guru/nidi/graphviz/service/SystemUtils.java50.00% <0.00%> (-13.16%)13.00% <0.00%> (-2.00%)
...ru/nidi/graphviz/engine/GraphvizCmdLineEngine.java86.40% <0.00%> (-0.98%)30.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c1fdf...a0eeb74. Read the comment docs.

@sirocchj

Copy link
Copy Markdown
Author

Hey @nidi3 what do you think about this? Does it make sense to you?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sirocchj@codecov-io