Skip to content

fix: exclude internal /_*, /api/_* routes from NitroFetchReqeust type - #232

Merged
pi0 merged 2 commits into
nitrojs:mainfrom
didavid61202:exclude-internal-routes-from-nitro-fetch-request
May 13, 2022
Merged

fix: exclude internal /_*, /api/_* routes from NitroFetchReqeust type#232
pi0 merged 2 commits into
nitrojs:mainfrom
didavid61202:exclude-internal-routes-from-nitro-fetch-request

Conversation

@didavid61202

@didavid61202didavid61202 commented May 12, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

fix#231

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

type NitroFetchRequest should exclude all /_* and /api/_* routes as they are for internal use and should not show type hints/auto-complete to end users.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

This was referenced May 12, 2022
Closed
Merged
pi0
pi0 reviewed May 12, 2022
View reviewed changes
Comment threadsrc/types/fetch.ts Outdated
@didavid61202@pi0
Update NitroFetchRequest
64e0c64
Co-authored-by: pooya parsa <pyapar@gmail.com>
@didavid61202
didavid61202 requested a review from pi0May 12, 2022 16:38
@pi0
pi0 merged commit 00aa131 into nitrojs:mainMay 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0pi0Awaiting requested review from pi0pi0 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: exclude all /_* and /api/_* routes from NitroFetchRequest type

2 participants

@didavid61202@pi0