fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(prerender): warn and keep first output when two routes collide - #4491

Open
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision
Open

fix(prerender): warn and keep first output when two routes collide#4491
sobol-sudo wants to merge 2 commits into
nitrojs:mainfrom
sobol-sudo:fix/prerender-output-collision

Conversation

@sobol-sudo

Copy link
Copy Markdown

🔗 Linked issue

Resolves the dedup half of #4487. The other half, the non-atomic write, is #4488 — the two are independent and this branch is cut from main, not from that one.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two prerender routes can resolve to a single output file — /other and /other/index.html both become other/index.html under autoSubfolderIndex. Nitro renders both and writes both to that one path, so the file that ships is whichever render happened to finish last, and nothing in the output says a route was discarded.

Nuxt produces exactly this pair without the user asking: it adds a prerender route /index.html alongside the page route / whenever ssr: false, and raises prerender.concurrency above 1.

The resolved fileName is only known after a route has been rendered, so this cannot be deduped when routes are queued. This tracks the file each route resolved to and, when a second route resolves to a file that is already taken, warns and skips the write instead of replacing the first route's output:

WARN Routes `/other` and `/other/index.html` both prerender to `/other/index.html`. Keeping the output of `/other`.

The skipped route is marked skip, so it already renders as (skipped) in the prerender log through formatPrerenderRoute. The file is claimed synchronously before the write is awaited, so a concurrent render resolving to the same file sees it as taken.

Which of the two routes wins is still the one that finished first, and with concurrency > 1 that is not deterministic. Making it deterministic would mean ordering the writes, which seemed like a bigger change than this warrants — the point here is that the build no longer silently discards a render, and the warning names both routes so the duplicate can be removed from the route list. Happy to go further if you would prefer the winner to be pinned to route order.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/prerender/collision.test.ts builds a small fixture with both routes and asserts the warning fires once, that only one route claims the file, and that the file holds that route's render. It fails on main (no warning, both routes recorded as written) and passes with this change.

Locally: test/unit 174 passed / 2 skipped, tsc --noEmit clean, oxlint and oxfmt --check clean.

@sobol-sudo
sobol-sudo requested a review from pi0 as a code ownerJuly 29, 2026 06:06
@vercel

vercelBot commented Jul 29, 2026

Copy link
Copy Markdown

@sobol-sudo is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e47f984b-941c-4824-9c14-83fdd32049f5

📥 Commits

Reviewing files that changed from the base of the PR and between 983d87b and fdc4f3b.

📒 Files selected for processing (2)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/prerender/collision.test.ts

📝 Walkthrough

Walkthrough

Changes

Prerender collision handling

Layer / File(s)Summary
Claim output files before writing
src/prerender/prerender.ts
Tracks the first route for each resolved output file, warns and skips later collisions, and claims files before asynchronous writes.
Validate colliding static routes
test/prerender/collision.test.ts, test/prerender/fixture/server.ts
Adds static prerender collision coverage, warning assertions, winner verification, generated HTML validation, and temporary-directory cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • nitrojs/nitro#4488 — Addresses concurrent writes to the same output path through atomic file replacement.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title follows conventional commits and accurately summarizes the prerender collision fix.
Description check✅ PassedThe description matches the changeset and explains the collision fix and new test clearly.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/prerender/prerender.ts`:
- Around line 114-117: Update the route deduplication map usage in the prerender
flow to key both lookups and insertions by the resolved filePath used for
writing, rather than the raw route.fileName. Ensure the checks and updates
around routeByOutputFile consistently use filePath so filename aliases resolving
to the same output are treated as one target.
In `@test/prerender/collision.test.ts`:
- Around line 20-40: Wrap the Nitro lifecycle operations in the collision test,
including prepare, copyPublicAssets, prerender, and build, in a try/finally
structure, and move nitro.close() into the finally block so it always executes
when setup or prerendering fails. Keep the existing warning capture and
operation order unchanged.
- Around line 42-52: Update the collision assertions in the prerender test to
require that the intended winning route is “/other”, rather than deriving the
expected content from written[0].route. Also verify the collision warning
explicitly names both competing routes, while preserving the existing
single-file assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3442a2-7c28-4070-9ee1-57bf1ecdc643

📥 Commits

Reviewing files that changed from the base of the PR and between 77b77ff and 983d87b.

📒 Files selected for processing (3)
  • src/prerender/prerender.ts
  • test/prerender/collision.test.ts
  • test/prerender/fixture/server.ts

Comment threadsrc/prerender/prerender.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Comment threadtest/prerender/collision.test.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sobol-sudo