Skip to content

fix: allow optional output property in user rollup config - #751

Merged
pi0 merged 1 commit into
mainfrom
fix/rollup-config-types
Dec 12, 2022
Merged

fix: allow optional output property in user rollup config#751
pi0 merged 1 commit into
mainfrom
fix/rollup-config-types

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This allows users to pass a rollupConfig that doesn't include an output property

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov

codecovBot commented Dec 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #751 (900604c) into main (b098cb1) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #751 +/- ##
=======================================
Coverage 72.35% 72.35% =======================================
Files 57 57 Lines 5123 5123 Branches 553 553 =======================================
Hits 3707 3707 Misses 1406 1406 Partials 10 10 
Impacted FilesCoverage Δ
src/types/nitro.ts100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0
pi0 merged commit 8186a02 into mainDec 12, 2022
@pi0
pi0 deleted the fix/rollup-config-types branch December 12, 2022 15:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0