error C2039: '_snprintf': is not a member of 'std' - Windows

[phunkyfish]

I used the latest release (single include file), compiled using VS2017 - Visual Studio 2017 Developer Command Prompt v15.9.1.

As a work around I removed std:: from all the snprintf calls.

I was building an addon for kodi: kodi-pvr/pvr.vuplus#156

Full gist of build output: https://gist.github.com/phunkyfish/c8456619bd85c16b1f9243e83517ac46

Note that it builds for all other platforms without issue.

[nlohmann]

This is strange, because the MSVC builds run without problems on AppVeyor, see https://ci.appveyor.com/project/nlohmann/json.

[phunkyfish]

Microsoft (R) Program Maintenance Utility Version 14.16.27023.1
Copyright (C) Microsoft Corporation.  All rights reserved.

d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(3930): error C2039: '_snprintf': is not a member of 'std'
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(20292): note: see declaration of 'std'
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(3921): note: while compiling class template member function 'std::string nlohmann::detail::lexer<nlohmann::basic_json<std::map,std::vector,std::string,bool,int64_t,uint64_t,double,std::allocator,nlohmann::adl_serializer>>::get_token_string(void) const'
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(5020): note: see reference to function template instantiation 'std::string nlohmann::detail::lexer<nlohmann::basic_json<std::map,std::vector,std::string,bool,int64_t,uint64_t,double,std::allocator,nlohmann::adl_serializer>>::get_token_string(void) const' being compiled
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(4967): note: see reference to class template instantiation 'nlohmann::detail::lexer<nlohmann::basic_json<std::map,std::vector,std::string,bool,int64_t,uint64_t,double,std::allocator,nlohmann::adl_serializer>>' being compiled
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(13447): note: see reference to class template instantiation 'nlohmann::detail::parser<nlohmann::basic_json<std::map,std::vector,std::string,bool,int64_t,uint64_t,double,std::allocator,nlohmann::adl_serializer>>' being compiled
d:\jenkins\workspace\binary-addons\kodi-windows-x86_64-master\tools\depends\target\binary-addons\pvr.vuplus\src\enigma2\utilities/json.hpp(20307): note: see reference to class template instantiation 'nlohmann::basic_json<std::map,std::vector,std::string,bool,int64_t,uint64_t,double,std::allocator,nlohmann::adl_serializer>' being compiled
NMAKE : fatal error U1077: 'C:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
Archiving artifacts
‘cmake/addons/build/zips/pvr.vuplus+windows-x86_64/pvr.vuplus-*.zip’ doesn’t match anything: ‘cmake’ exists but not ‘cmake/addons/build/zips/pvr.vuplus+windows-x86_64/pvr.vuplus-*.zip’
No artifacts found that match the file pattern "cmake/addons/build/zips/pvr.vuplus+windows-x86_64/pvr.vuplus-*.zip". Configuration error?```

[phunkyfish]

Might it be the version: Utility Version 14.16.27023.1

[nlohmann]

It seems that Microsoft somewhere uses a macro and forwards snprintf to _snprintf and then the resulting code std::_snprintf makes no sense. I'll check what I can do.

[phunkyfish]

Json CPP had similar problem.

open-source-parsers/jsoncpp#224

Maybe you just need to add:

#if defined(_MSC_VER) && _MSC_VER < 1500 // VC++ 8.0 and below
#define snprintf _snprintf

To support version earlier than 15

[nlohmann]

Sigh... Yet another instance where I need to "patch" C++11 code such that it can compile with the most recent Microsoft compiler...

[phunkyfish]

Unfortunately that’s not uncommon.

[gregmarr]

Are you sure this definition is from VC++ itself and not some other library that you're including?

[phunkyfish]

I’m not sure at all. While developing I build the addon on Mac which doesn’t have the issue. The windows build happens on the automated build system for the addon.

[1996sc30]

Are you sure this definition is from VC++ itself and not some other library that you're including?

I also had this problem, but the query found that other libraries defined it. I am also very upset now.

[phunkyfish]

This is tricky, my guess is the occurrences of this will rise with adoption and it will be difficult to define to users what the correct workaround is.

[nlohmann]

@1996sc30 You are saying that the define came from another library, but not this one? Meaning the error has nothing to do with this library?

[1996sc30]

@1996sc30 You are saying that the define came from another library, but not this one? Meaning the error has nothing to do with this library?

Yes！Indeed so.