Skip to content

Incorrect CMake FetchContent example #2142

Closed
#2143
Closed
Incorrect CMake FetchContent example#2142
#2143
Labels
documentationkind: bugrelease item: 🔨 further changesolution: proposed fixa fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Description

@quentin-dev
quentin-dev
opened on May 27, 2020

What is the issue you have?

The README section about CMake FetchContent integration seems to have a typo

FetchContent_Declare(json
  GIT_REPOSITORY https://github.com/nlohmann/json
  GIT_TAG v3.7.3)

Should be

FetchContent_Declare(json
  GIT_REPOSITORY https://github.com/nlohmann/json.git
  GIT_TAG v3.7.3)

as is shown in the examples given by CMake

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationkind: bugrelease item: 🔨 further changesolution: proposed fixa fix for the issue has been proposed and waits for confirmation

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions