CMake target nlohmann_json does not have src into its interface includes

[sogartar]

If you do in CMake:

add_subdirectory(nlohmann/json)
target_link_libraries(my_target PRIVATE nlohmann_json)

Then my_target does not have nlohmann/json/src into its includes, where json.hpp is. You can not properly include this project into other CMake projects.
Note that in v2.1.1 it used to be OK.

[nlohmann]

maybe related: #695

[dan-42]

@sogartar what system do you use? Windows? Mac? Linux?
have you installed it first via?

cmake
make
make install

If the usage you described is a common one (I did never useed 3rdparty CMake-Projekts like this)
Then indeed this might be a BUG.
Please not that the up comming version V3.0.0 will bring breaking changes including the usage of build-tools and package-managers. see #698

[dan-42]

@sogartar I forgot, a simpler oneliner for your case could be

include_directory(nlohmann/json/src)

[nlohmann]

Is there anything to be done to close this issue?

[sogartar]

I think you should add nlohmann/json/src to the public includes of the nlohmann_json target. See target_include_directories.

[dan-42]

Well @sogartar thx for answering any of my questions. so IMHO I would ignore it.

But I will have a look and see what impact the suggestion would be.

[nlohmann]

Does anyone has an idea how to proceed here?

[nlohmann]

Issue #790 also proposes to change the include dir.

[nlohmann]

Sorry, #790 is unrelated to this issue.

[nlohmann]

I need more info on this issue. What needs to be fixed? Is there example code to demonstrate the issue?