Skip to content

recommend using explicit from JSON conversions - #1363

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
theodelrieu:doc/implicit_conversions
Dec 2, 2018
Merged

nlohmann merged 1 commit into
nlohmann:developfrom
theodelrieu:doc/implicit_conversions

Conversation

@theodelrieu

@theodelrieu theodelrieu commented Nov 19, 2018

Copy link
Copy Markdown
Contributor

This is the minimum we can do about #958.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls

coveralls commented Nov 19, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 7b96136 on theodelrieu:doc/implicit_conversions into da81e7b on nlohmann:develop.

@theodelrieu
theodelrieu force-pushed the doc/implicit_conversions branch from 86b16a3 to 7b96136 Compare November 20, 2018 13:14
@theodelrieu

Copy link
Copy Markdown
Contributor Author

@nlohmann Any update on this one?

@nlohmann

nlohmann commented Dec 1, 2018

Copy link
Copy Markdown
Owner

Sorry, did not find the time. I’ll try to check tomorrow.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Dec 2, 2018
@nlohmann nlohmann added this to the Release 3.4.1 milestone Dec 2, 2018
@nlohmann
nlohmann merged commit d53873a into nlohmann:develop Dec 2, 2018
@nlohmann

nlohmann commented Dec 2, 2018

Copy link
Copy Markdown
Owner

Thanks!

@theodelrieu
theodelrieu deleted the doc/implicit_conversions branch December 3, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants