test/CMakeLists.txt: Use an explicit list instead of GLOB - #1779
Merged
Merged
Conversation
Using GLOB is slow and considered bad practice. From https://cmake.org/cmake/help/latest/command/file.html: > We do not recommend using GLOB to collect a list of source files from > your source tree. If no CMakeLists.txt file changes when a source is > added or removed then the generated build system cannot know when to ask > CMake to regenerate. The CONFIGURE_DEPENDS flag may not work reliably on > all generators, or if a new generator is added in the future that cannot > support it, projects using it will be stuck. Even if CONFIGURE_DEPENDS > works reliably, there is still a cost to perform the check on every > rebuild.
Owner
|
Thansk! |
Owner
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using GLOB is slow and considered bad practice.
From https://cmake.org/cmake/help/latest/command/file.html:
Close #1686.