Add pkg-config file - #2253
Merged
Merged
Add pkg-config file#2253
Conversation
nlohmann
requested changes
Jul 9, 2020
nlohmann
left a comment
Owner
There was a problem hiding this comment.
Could you please rename the file to pkg-config.pc.in, put it into the cmake folder, and adjust the CMakeLists.txt accordingly?
The meson builds install a pkg-config file, but the cmake builds don't. This adds a pkg-config file to the cmake builds that is functionally equivalent to the one generated from meson.
Contributor
Author
|
Done! Would you prefer I used |
Owner
|
I think CMAKE_CURRENT_SOURCE_DIR is less surprising. |
Owner
|
Thanks! |
Owner
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Owner
|
FYI: The |
Contributor
Author
|
I see, thanks! |
Contributor
|
Somehow this managed to completely break |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pkg-config generation to the CMake build system, functionally the same as the pkg-config generated by Meson. This PR is picking up on the work from #1701 .
Pull request checklist