Skip to content

Add missing files to release artifacts - #3728

Merged
nlohmann merged 2 commits into
nlohmann:developfrom
falbrechtskirchinger:add-missing-release-files
Sep 25, 2022
Merged

Add missing files to release artifacts#3728
nlohmann merged 2 commits into
nlohmann:developfrom
falbrechtskirchinger:add-missing-release-files

Conversation

@falbrechtskirchinger

@falbrechtskirchinger falbrechtskirchinger commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add missing files to include.zip:

  • amalgamated json_fwd.hpp
  • Bazel build files

Fixes #3727.

@github-actions github-actions Bot added the S label Sep 7, 2022
@falbrechtskirchinger

falbrechtskirchinger commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author 
$ make include.zip
(...)
  adding: single_include/nlohmann/json_fwd.hpp (deflated 74%)
  adding: BUILD.bazel (deflated 81%)
  adding: WORKSPACE.bazel (stored 0%)

@falbrechtskirchinger
falbrechtskirchinger marked this pull request as draft September 7, 2022 07:22
@falbrechtskirchinger

falbrechtskirchinger commented Sep 7, 2022

Copy link
Copy Markdown
Contributor Author

(Let's wait on #3709.)

@coveralls

coveralls commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 2b3a1d4 on falbrechtskirchinger:add-missing-release-files into f4658de on nlohmann:develop.

@falbrechtskirchinger
falbrechtskirchinger marked this pull request as ready for review September 20, 2022 06:52
@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 25, 2022
nlohmann
nlohmann approved these changes Sep 25, 2022
View reviewed changes

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann
nlohmann merged commit 17d9eac into nlohmann:develop Sep 25, 2022
@nlohmann

nlohmann commented Sep 25, 2022

Copy link
Copy Markdown
Owner

Thanks!

@falbrechtskirchinger
falbrechtskirchinger deleted the add-missing-release-files branch September 25, 2022 11:55
@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes
+1 more reviewer
@gregmarr gregmarr gregmarr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S

Projects

None yet

Milestone

Release 3.11.3

Development

Successfully merging this pull request may close these issues.

Amalgated json_fwd.hpp not included in include.zip

4 participants

@falbrechtskirchinger @coveralls @nlohmann @gregmarr