Conversation
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @fmeum Please read and follow the Contribution Guidelines. |
Owner
@falbrechtskirchinger The warning is odd - the sources have not been touched. Or do I miss anything? |
By adding a MODULE.bazel file, this library becomes usable with Bazel's new external dependency management system Bzlmod. The new tests are run when a new version is included in the Bazel Central Registry and verify that the basic functionality works with the provided Bazel setup. See: https://bazel.build/build/bzlmod
Author
|
@nlohmann The amalgamation check appears to run the formatter on |
Owner
|
My bad. Thanks for the quick response! |
Author
|
I will leave this in draft until I have confirmed it works over at bazelbuild/bazel-central-registry#248. |
Author
Author
|
bazelbuild/bazel-central-registry#359 has added the module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding a MODULE.bazel file, this library becomes usable with Bazel's new external dependency management system Bzlmod.
The new tests are run when a new version is included in the Bazel Central Registry and verify that the basic functionality works with the provided Bazel setup.
See:
https://bazel.build/build/bzlmod
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.Please don't
#ifdefs or other means.