Conversation
tnotheis
force-pushed
the
fix/recover-missing-datawallet
branch
from
September 16, 2026 08:19
e61dfb7 to
96bc4d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Backbone creates a Datawallet only when a Datawallet version upgrade sync run is finalized. If a Connector is interrupted after creating its identity but before that finalize request succeeds, the local identity remains persisted without a Backbone Datawallet. Every later startup then fails on
GET /Datawalletand never retries the creation flow.When the Backbone explicitly returns
error.platform.recordNotFoundforGET /Datawallet, the sync controller now recreates the Datawallet at the supported version and includes the still-unpushed local modifications. Other request failures, including unspecific HTTP 404 responses, continue to propagate unchanged.A regression test covers the recovery path.
Readiness checklist