Skip to content

Remove solid:inbox. - #794

Merged
RubenVerborgh merged 1 commit into
release/v5.0.0from
fix/ldp-inbox
Oct 25, 2018
Merged

Remove solid:inbox.#794
RubenVerborgh merged 1 commit into
release/v5.0.0from
fix/ldp-inbox

Conversation

@RubenVerborgh

Copy link
Copy Markdown
Contributor

@kjetilk

Copy link
Copy Markdown
Member

This is something that should probably go into the v5.0.0 branch?

@RubenVerborgh

Copy link
Copy Markdown
ContributorAuthor

@kjetilk Good pointt.

@RubenVerborghRubenVerborgh added the semver-major Involves breaking API changes label Sep 30, 2018
@RubenVerborgh
RubenVerborgh changed the base branch from develop to release/v5.0.0September 30, 2018 18:53
@melvincarvalho

Copy link
Copy Markdown
Contributor

Just FYI: it's been on my todo list for ages, to add solid : inbox back to the vocabulary only.

It was removed by mistake, before we had a process of pull requests and review.

@csarven

Copy link
Copy Markdown
Member

It wasn't removed by mistake, ldp:inbox replaces it. LDN standardises the notification system.

@melvincarvalho

Copy link
Copy Markdown
Contributor

@csarven thanks for sharing your view. However, this is a discussion for the vocab repo.

@RubenVerborgh

RubenVerborgh commented Oct 25, 2018

Copy link
Copy Markdown
ContributorAuthor

As discussed in https://github.com/solid/vocab/issue/31 and solid/vocab#33, it's ldp:inbox now. Rebasing and merging.

@RubenVerborgh
RubenVerborgh merged commit 100b156 into release/v5.0.0Oct 25, 2018
@RubenVerborgh
RubenVerborgh deleted the fix/ldp-inbox branch October 25, 2018 13:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugready for reviewsemver-majorInvolves breaking API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@RubenVerborgh@kjetilk@melvincarvalho@csarven@bourgeoa