Skip to content

Fix #26: Correct solidWs naming and syntax error in README - #27

Open
melvincarvalho wants to merge 1 commit into
nodeSolidServer:mainfrom
melvincarvalho:main
Open

Fix #26: Correct solidWs naming and syntax error in README#27
melvincarvalho wants to merge 1 commit into
nodeSolidServer:mainfrom
melvincarvalho:main

Conversation

@melvincarvalho

Copy link
Copy Markdown
Contributor

No description provided.

@bourgeoa

bourgeoa commented Oct 9, 2024

Copy link
Copy Markdown
Member

@melvincarvalho

Copy link
Copy Markdown
ContributorAuthor

I think that might be another typo. But anyway, the example in the README isn't working:

varSolidWs=require('solid-ws')varldnode=require('ldnode')varserver=ldnode.createServer()solidWs(server)

@melvincarvalho

Copy link
Copy Markdown
ContributorAuthor

Bump on this. Can we agree that the code above in the README is broken?

@TallTed

Copy link
Copy Markdown
Member

@melvincarvalho — To be clear...

You say the example in the README doesn't work today (with SolidWs).

Can you confirm that the example does work with your change (to solidWs)?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@melvincarvalho@bourgeoa@TallTed