Skip to content

doc: update release dates - #434

Merged
BethGriggs merged 7 commits into
nodejs:masterfrom
BethGriggs:updates
Apr 16, 2019
Merged

doc: update release dates#434
BethGriggs merged 7 commits into
nodejs:masterfrom
BethGriggs:updates

Conversation

@BethGriggs

@BethGriggsBethGriggs commented Apr 12, 2019

Copy link
Copy Markdown
Member

No description provided.

@BethGriggs

BethGriggs commented Apr 12, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@nodejs/release PTAL at the estimated dates for the next few releases. Also, could someone please link me to the tool that generates the timeline image?

Refs: #431 /cc @sam-github

@jasonkarns, I've set the schedule.json to put v11.x into "maintenance" on 2019-04-22, and v12.x to start on 2019-04-23. Does this work?

@richardlau

richardlau commented Apr 12, 2019

Copy link
Copy Markdown
Member

Also, could someone please link me to the tool that generates the timeline image?

@BethGriggshttps://github.com/nodejs/lts-schedule, See also #380 (comment).

targos
targos approved these changes Apr 12, 2019
View reviewed changes
Comment threadschedule.json Outdated
@targos@BethGriggs
fixup: extend v13.x maintenance to remove "current" gap
3861b93
Co-Authored-By: BethGriggs <bethany.griggs@uk.ibm.com>
MylesBorins
MylesBorins approved these changes Apr 12, 2019
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins
MylesBorins reviewed Apr 12, 2019
View reviewed changes
Comment threadschedule.json
"lts": "2019-10-22",
"maintenance": "2021-04-01",
"end": "2022-04-01",
"codename": ""

@MylesBorinsMylesBorinsApr 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep the codename here?

Suggested change
"codename": ""
"codename": "TBD"

mhdawson
mhdawson approved these changes Apr 12, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonkarns

jasonkarns commented Apr 13, 2019

Copy link
Copy Markdown
Member

I've set the schedule.json to put v11.x into "maintenance" on 2019-04-22, and v12.x to start on 2019-04-23. Does this work

@BethGriggs that's perfect, thanks!

@BethGriggs

BethGriggs commented Apr 15, 2019

Copy link
Copy Markdown
MemberAuthor

Screenshot 2019-04-15 at 16 42 51

@nodejs/release, I have updated the timeline SVG - does this look ok?

@MylesBorins

MylesBorins commented Apr 15, 2019

Copy link
Copy Markdown
Contributor

LGTM

@BethGriggs
BethGriggs merged commit f4ae92f into nodejs:masterApr 16, 2019
@BethGriggsBethGriggs mentioned this pull request Apr 24, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes
+3 more reviewers
@MylesBorinsMylesBorinsMylesBorins approved these changes
@targostargostargos approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BethGriggs@richardlau@jasonkarns@MylesBorins@jasnell@targos@mhdawson