Uh oh!
There was an error while loading. Please reload this page.
add inclusivity working group - #29
Conversation
jasnell
commented
Jan 11, 2016
LGTM |
jasnell
commented
Jan 11, 2016
@nodejs/tsc |
mikeal
commented
Jan 12, 2016
Looks great :) |
rvagg
commented
Jan 13, 2016
A couple of different bullet-point styles in use there ( I see we have an unfortunate mix of >2 styles in the core repo WORKING_GROUPS.md, perhaps we can pick a style here and update there afterwards. |
ashleygwilliams
commented
Jan 13, 2016
totally @rvagg! good feedback. i was actually copying what i saw in the core any preference? (i have none except preferring consistency, which it seems we share 😄) |
jasnell
commented
Jan 13, 2016
Lol yeah, we gotta fix the styles in that one too
|
rvagg
commented
Jan 13, 2016
Looking over other top-level .md files I think I'm seeing this format showing up the most, although there is a bit of variation: This is the style I personally use but in this case I only care about consistency. @nodejs/documentation suggestions for a style to adopt? Perhaps we have a prevailing style in the docs? |
ashleygwilliams
commented
Jan 13, 2016
wfm. i'll update + amend. |
ashleygwilliams
commented
Jan 13, 2016
oh whoops, missed your ask of @nodejs/documentation. will hold off til tomorrow. |
rvagg
commented
Jan 13, 2016
@ashleygwilliams my vote for now would be to just adopt a consistent style and we'll do a general cleanup later across files. I'd love if @nodejs/documentation could head that but I'm not sure they are organised enough yet. |
ashleygwilliams
commented
Jan 13, 2016
fair enough! incoming. |
583447b to
d1d0f00Compareashleygwilliams
commented
Jan 13, 2016
updated this @rvagg ICYMI. if yer just busy or working on something else, no worries! |
jasnell
commented
Jan 13, 2016
Still LGTM :-) ... one minor nit tho @ashleygwilliams ... the |
ashleygwilliams
commented
Jan 13, 2016
ah, excellent catch @jasnell -- do you have a preference re: solution? i think removing the |
jasnell
commented
Jan 13, 2016
I'm good with either. Begone with the #! ;)
|
ashleygwilliams
commented
Jan 13, 2016
incoming. |
d1d0f00 to
2fef297Comparejasnell
commented
Jan 13, 2016
Excellent. Thanks much. I'll wait for @rvagg to weigh in before landing... but will go ahead and land tomorrow if there are no objections posted. |
2fef297 to
72d1433Compareashleygwilliams
commented
Jan 13, 2016
heh, actually, i moved it up and made it a |
jasnell
commented
Jan 13, 2016
That works too! |
rvagg
commented
Jan 14, 2016
added |
ashleygwilliams
commented
Jan 14, 2016
thanks for the update @rvagg ! |
jasnell
commented
Jan 14, 2016
This was just discussed on the TSC call. There were no objections! We should be good to go. I'll get this landed shortly. |
mikeal
commented
Jan 14, 2016
Ratified in the TSC meeting on Jan 14th. |
ghost
commented
Jan 14, 2016
WOOT |
nebrius
commented
Jan 14, 2016
🎉 |
zkat
commented
Jan 14, 2016
🎉👏!! (post edited 2015-01-15 @ 8:10pm pacific by jasnell to remove a troublesome emoji ... per #29 (comment)) |
jasnell
commented
Jan 14, 2016
@zkat .. hmm.. just a side note: given the issues we've had with having to moderate users who post comments with eggplants, it's likely not the best choice to include one in #29 (comment). I know your intent is not to troll, but it would be rather hypocritical of us to not apply the same moderation criteria to your post as we do others :-) |

fixes: nodejs/inclusivity#69