Skip to content

assets: additional asset for v11.x - #1673

Merged
rvagg merged 1 commit into
nodejs:masterfrom
MylesBorins:additional-11.x-assets
Feb 28, 2019
Merged

assets: additional asset for v11.x#1673
rvagg merged 1 commit into
nodejs:masterfrom
MylesBorins:additional-11.x-assets

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

@refack

refack commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

Is it needed for v10.x as well (Ref nodejs/node#22716)?

@MylesBorins

MylesBorins commented Jan 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@refack I just took a peak at the assets for the release that needs to be promoted today and not seeing that file.

@targos

targos commented Jan 29, 2019

Copy link
Copy Markdown
Member

From the description in nodejs/node#25019, it looks like it wasn't intended to make this part of the published files?

@MylesBorins

MylesBorins commented Jan 29, 2019

Copy link
Copy Markdown
ContributorAuthor

hmmmm it has continued to be in the built assets so perhaps we need to revisit this?

/cc @joyeecheung

@refack

refack commented Jan 30, 2019

Copy link
Copy Markdown
Contributor

From the description in nodejs/node#25019, it looks like it wasn't intended to make this part of the published files?

AFAIK they are supposed to be published (nodejs/node#22405). They are what enable the [src] links in the docs, e.g.
image
which point to https://github.com/nodejs/node/blob/11ee7946b6b992a7dc8927cb38933475135f36a3/lib/fs.js#L172

mhdawson
mhdawson approved these changes Jan 30, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semi rubber stamp LGTM, seems reasonable that we would need them and @refack has confirmed that we do.

@rvagg
rvagg merged commit 6098487 into nodejs:masterFeb 28, 2019
@rvaggrvagg mentioned this pull request Feb 28, 2019
Merged
richardlau added a commit to richardlau/build that referenced this pull request Apr 9, 2020
@richardlau
promote: add additional asset for v10.x
1f5e87b
`docs/apilinks.json` was added in v10.15.3.
Refs: nodejs/node#25019
Refs: nodejs#1673
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
@richardlaurichardlau mentioned this pull request Apr 9, 2020
Merged
rvagg pushed a commit that referenced this pull request Apr 13, 2020
@richardlau@rvagg
promote: add additional asset for v10.x
8c2444d
`docs/apilinks.json` was added in v10.15.3.
Refs: nodejs/node#25019
Refs: #1673
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawsonmhdawsonmhdawson approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-releasewebsite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins@refack@targos@mhdawson@rvagg