Uh oh!
There was an error while loading. Please reload this page.
jenkins: stop testing 14.x on OSX10.11 - #2248
Merged
Merged
Conversation
AshCrippsforce-pushed
the
stop-14.x-test-mac
branch
from
March 25, 2020 10:23
e778b2e to
05e949eCompareUh oh!
There was an error while loading. Please reload this page.
AshCrippsforce-pushed
the
stop-14.x-test-mac
branch
from
March 25, 2020 10:49
8e1ea3a to
f1b43cfComparerichardlau
approved these changes
Mar 25, 2020
rvagg
approved these changes
Mar 25, 2020
rvagg
commented
Mar 25, 2020
Member
change the commit prefix to "jenkins:" before you land this btw |
AshCripps
commented
Mar 25, 2020
MemberAuthor
whoops autopilot |
once nodejs/node#32454 lands it doesnt make sense to test master on 10.11 anymore with the deployment target set to 10.13 refs: nodejs/node#32454
AshCrippsforce-pushed
the
stop-14.x-test-mac
branch
from
March 25, 2020 11:54
f1b43cf to
69a1a75Comparesam-github
approved these changes
Mar 25, 2020
richardlau
commented
Mar 26, 2020
Member
nodejs/node#32454 has landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think ive got this right, once nodejs/node#32454 lands it doesnt make
sense to test master on 10.11 anymore with the deployment target set to
10.13. So setting the versionselector to not test 14.x+ on osx10.11
refs: nodejs/node#32454