chore: mark pino as flaky

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.

[ruyadorno]

Marking pino as flaking since it's failing in many platforms for both v18.x and v20.x release lines.

Refs: #988

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (cd1b288) to head (cc9f984).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
==========================================
- Coverage 96.44% 93.17% -3.28% 
==========================================
Files 28 28 Lines 2139 2139 ==========================================
- Hits 2063 1993 -70 - Misses 76 146 +70 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

Should be fixed now.

[mcollina]

here is a rerun of the last one I've seen with pino failing:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3304/

[mcollina]

@ruyadorno my understanding is this is passing according to the current list of skipped environments: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/.

I don't expect it to pass on those other platforms, mostly because the errors are not in pino itself.

[RafaelGSS]

I agree with @mcollina, it seems to be working as expected. New CITGM just for the sake of conscience https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

[alfonsograziano]

Pino is still failing on 2 platforms in the last run on v18.18

Any idea on what to do in this case?

[mcollina]

Either lets skip it there or wait a few days that I can take a look.

[alfonsograziano]

I'd say, since Pino is such an important tool in the ecosystem, is better to have a failing CI for a few days and wait for a fix, rather than skipping the module. Thanks a lot for the help Matteo, super appreciated 🙏

[mcollina]

Fresh run of v18.18 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3311/

[alfonsograziano]

Awesome Matteo, thanks for the quick fix 🚀
@ruyadorno I guess we can safely close this PR and also #988 now :)

[mcollina]

I think this is fixed. Let me know if there is anything else here.

[ruyadorno]

Well it doesn't look like it has been completely fixed as it's looking like it's still timing out on both rhel8-ppc64le and win-vs2019 even in that fresh run (#3311). We should keep an eye on future runs to see if it's just these platforms that can be marked flaky and then update this PR accordingly.