lookup: add allow-git for JSONStream

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.

[MikeMcC399]

• relates to Archived (unsupported) packages - JSONStream, leveldown & q etc. #1113
• alternative to lookup: remove JSONStream #1114

Situation

JSONStream fails under npm 12.

See #1114 (comment) for steps to reproduce and for logs.

It is blocked by npm 12 as described in the logs:

npm error Fetching packages of type "git" have been disablednpm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"

https://github.com/dominictarr/JSONStream was archived Dec 4, 2018 and is therefore unsupported, since issues can no longer be logged, and new releases are no longer possible.

#1114 proposed to remove JSONStream, however @ljharb stated that it needed to be retained, since it exercises the use of a package name with uppercase characters.

Change

Modify entry for JSONStream in lib/lookup.json to add:

"npm_config_allow_git": "all"

which allows it to run under npm 12. See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git.

Checklist

• npm test passes
• contribution guidelines followed
  here

Note

https://github.com/dominictarr/JSONStream remains unsupported.

To test the ability to use a package that includes uppercase characters, an active package would be preferable to JSONStream, however it hasn't been possible to identify any alternative so far. Commonly-used packages conform to npm naming rules introduced several years ago that prohibit the introduction of new packages with names including uppercase characters. See npm blog post from Dec 26, 2017.

https://docs.npmjs.com/creating-a-package-json-file

The "name" field contains your package's name and must be lowercase without any spaces. May contain hyphens, dots, and underscores.

JSONStream has flaky results on macOS and a hard fail on Windows, unrelated to the change to allow git:

Node.js	npm	macos	ubuntu	windows
22.23.1	10.9.8	pass	pass	HARD FAIL
24.19.0	11.17.0	FLAKE FAIL	pass	pass
26.7.0	11.19.0	pass	pass	pass
26.7.0	12.0.2	FLAKE FAIL	pass	pass

error: | *** destroy_missing.js ***error: |error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\package.json' of './assert.js'. Please either fix that or report it to the module authorerror: | (Use `node --trace-deprecation ...` to show where the warning was created)error: | (node:7984) [DEP0128] DeprecationWarning: Invalid 'main' field in '\\?\C:\Users\RUNNER~1\AppData\Local\Temp\7c04b44f\JSONStream\node_modules\it-is\node_modules\assertions\node_modules\traverser\package.json' of './traverser.sync'. Please either fix that or report it to the module authorerror: | PASSEDerror: | node:events:497error: | throw er; // Unhandled 'error' eventerror: | ^error: |error: | Error: This socket has been ended by the other party

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (eef880d) to head (3c94cfe).

Additional details and impacted files

@@ Coverage Diff @@## main #1127 +/- ##
=======================================
Coverage 96.20% 96.20% =======================================
Files 29 29 Lines 2213 2213 =======================================
Hits 2129 2129 Misses 84 84 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@ljharb
Are you planning to merge this, now that you approved it?

[ljharb]

I've never merged anything here, so I'm a bit hesitant to do so myself.

[MikeMcC399]

I've never merged anything here, so I'm a bit hesitant to do so myself.

Perhaps the @nodejs/citgm team can advise how it intends to handle PRs from submitters like me who are not part of the team? I don't feel comfortable routinely pinging @targos to get attention, unless that is what is wanted.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/285/
CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/286/

[MikeMcC399]

Hi @targos

If you're running in Jenkins, please note the comments about expected failures in Windows and macOS.

I would prefer to remove this module completely. See alternative #1114
@ljharb wants to keep it, even though it's unsupported and fails in Windows and macOS, because it has a mixed case name.

[MikeMcC399]

I did a local test in https://github.com/MikeMcC399/citgm/actions/runs/31591814283 which also tests against npm 12. It shows the failures also.

[ljharb]

(to reiterate, if we can find an alternative mixed case package to include, then JSONStream can be dropped in favor of that)

[MikeMcC399]

Although adding allow-git to the unsupported JSONStream does not make the test results for npm 10 & 11 worse than they were before, it is difficult to justify further effort here.

There has been no supported npm package with a legacy mixed case name identified and it is possible that no such package even exists anymore. If that is the case, then keeping JSONStream in citgm has no benefit.