Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/rules/line-length.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,10 +29,14 @@ export default {
let failed = false
for (let i = 0; i < parsed.body.length; i++) {
const line = parsed.body[i]

// Skip quoted lines, e.g. for original commit messages of V8 backports.
if (line.startsWith(' ')) { continue }
// Skip lines with URLs.
if (/https?:\/\//.test(line)) { continue }
// Skip co-authorship.
if (/^co-authored-by:/i.test(line)) { continue }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure it's worth doing, but we could have a shared util to avoid duplicating the regex

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think if we need it in a third place, then it's worth having a shared util.


if (line.length > len) {
failed = true
context.report({
Expand Down
32 changes: 32 additions & 0 deletions test/rules/line-length.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -129,5 +129,37 @@ https://${'very-'.repeat(80)}-long-url.org/
tt.end()
})

t.test('Co-author lines', (tt) => {
const v = new Validator()

const good = new Commit({
sha: 'f1496de5a7d5474e39eafaafe6f79befe5883a5b',
author: {
name: 'Jacob Smith',
email: '3012099+JakobJingleheimer@users.noreply.github.com',
date: '2025-12-22T09:40:42Z'
},
message: [
'fixup!: apply case-insensitive suggestion',
'Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>'
].join('\n')
}, v)

good.report = (opts) => {
tt.pass('called report')
tt.equal(opts.id, 'line-length', 'id')
tt.equal(opts.string, '', 'string')
tt.equal(opts.level, 'pass', 'level')
}

Rule.validate(good, {
options: {
length: 72
}
})

tt.end()
})

t.end()
})