Uh oh!
There was an error while loading. Please reload this page.
feat: add support for stdin JSON input - #135
Conversation
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Thanks for handling this :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ls.on('close', (code) => { | ||
| tt.equal(code, 1, 'CLI exits with non-zero code on error') | ||
| tt.match(errorData, /Input must be an array/, 'error message is shown') |
There was a problem hiding this comment.
This seems likely to create bad DX. If it's not an array, just wrap it in an array.
There was a problem hiding this comment.
If there's a use-case for passing a non-array, we can consider it. Until then, it's probably more helpful to throw an error.
There was a problem hiding this comment.
I meant I think it's a likely mistake a user could make, and throwing will just especially frustrate the user "god dammit" because they'll likely know how easy it was to just handle it.
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
The goal is to remove the need to clone the repo in https://github.com/nodejs/node/blob/main/.github/workflows/notify-on-push.yml, and instead rely on
push.commitslike so: