Skip to content

add worker to subsystems and add subsystems tests - #42

Merged
richardlau merged 2 commits into
nodejs:masterfrom
Trott:worker_threads
Jan 11, 2019
Merged

add worker to subsystems and add subsystems tests#42
richardlau merged 2 commits into
nodejs:masterfrom
Trott:worker_threads

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

Comment threadlib/rules/subsystem.js Outdated
@Trott

Copy link
Copy Markdown
MemberAuthor

There appears to be far more enthusiasm for continuing to use worker as the subsystem rather than switching to worker_threads so I've updated this PR to reflect this. Let's get this approved, landed, and released, so I can land a bunch of worker-related PRs without bypassing the tooling!

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott changed the title add worker_threads to subsystems and add subsystems testsadd worker to subsystems and add subsystems testsJan 11, 2019
@richardlau
richardlau merged commit d2b2295 into nodejs:masterJan 11, 2019
@richardlau

Copy link
Copy Markdown
Member

I've published v3.8.0 following instructions on #35 (comment).

This is the first time I've done this, so please let me know if I've done anything wrong! 🙏

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@richardlau@mcollina@addaleax@joyeecheung