Skip to content

test: Add test for Rule class. - #74

Merged
richardlau merged 2 commits into
nodejs:masterfrom
lholmquist:rules-tests-coverage
Aug 15, 2019
Merged

test: Add test for Rule class.#74
richardlau merged 2 commits into
nodejs:masterfrom
lholmquist:rules-tests-coverage

Conversation

@lholmquist

Copy link
Copy Markdown
Contributor
  • This adds two tests for the Rules class testing the error conditions for when a rule does not have an id parameter or a validate function.

While going through #73 and #70 I noticed that this class was missing a couple test cases.

This should bring the test coverage up to 100% for that particular file

* This adds two tests for the Rules class testing the error conditions for when a rule does not have an id parameter or a validate function.
@codecov

codecovBot commented Aug 2, 2019

Copy link
Copy Markdown

Codecov Report

Merging #74 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #74 +/- ##
==========================================
+ Coverage 57.14% 57.58% +0.44% 
==========================================
Files 18 18 Lines 448 448 ==========================================
+ Hits 256 258 +2 + Misses 192 190 -2
Impacted FilesCoverage Δ
lib/rule.js100% <0%> (+15.38%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479fe81...dd5ffe0. Read the comment docs.

Comment threadtest/rule-test.js Outdated
@lholmquist
lholmquistforce-pushed the rules-tests-coverage branch from 4c45b9f to dd5ffe0CompareAugust 5, 2019 19:23
@lholmquist

lholmquist commented Aug 5, 2019

Copy link
Copy Markdown
ContributorAuthor

i must have renamed the files before i sent the PR, but never closed the the old delete file in my editor, so that showed up in a commit. 🤷‍♂️

I forced pushed new changes based on the feedback about using tap.throws

@lholmquist

Copy link
Copy Markdown
ContributorAuthor

Not sure if this one got lost in the flurry of other PR's i sent in :)

Just a friendly ping

@richardlau
richardlau merged commit a9f7439 into nodejs:masterAug 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lholmquist@tniessen@richardlau