Uh oh!
There was an error while loading. Please reload this page.
fix!: call executePackageManagerRequest directly - #430
Merged
merceyz merged 3 commits intoApr 20, 2024
Merged
Conversation
aduh95
reviewed
Mar 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
merceyzforce-pushed
the
merceyz/perf/call-executePackageManagerRequest-directly
branch
from
March 15, 2024 22:16
d1b5d0b to
0a0359eComparemerceyzforce-pushed
the
merceyz/perf/call-executePackageManagerRequest-directly
branch
from
April 20, 2024 12:48
0a0359e to
ab77bb5CompareCo-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
merceyzforce-pushed
the
merceyz/perf/call-executePackageManagerRequest-directly
branch
from
April 20, 2024 12:51
ab77bb5 to
6e62f29CompareexecutePackageManagerRequest directlyexecutePackageManagerRequest directlymerceyz
marked this pull request as ready for review
April 20, 2024 12:54
merceyzforce-pushed
the
merceyz/perf/call-executePackageManagerRequest-directly
branch
from
April 20, 2024 13:21
dfddf92 to
a82e453Compareaduh95
approved these changes
Apr 20, 2024
merceyz
deleted the
merceyz/perf/call-executePackageManagerRequest-directly
branch
April 20, 2024 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
executePackageManagerRequestdirectly instead of through Clipanion lets Node.js handle printing errors which results in thecauseproperty being printed correctly.Ref #458 and others like it.
Ref #425 (comment)
Depends on
Cancellationerror #428Performance is roughly the same
BREAKING CHANGE:
Some errors are now printed to stderr instead of stdout