Skip to content

feat: download only yarn.js from npm - #439

Merged
aduh95 merged 21 commits into
nodejs:mainfrom
zhyupe:fix/yarn-berry-hash
Apr 1, 2024
Merged

feat: download only yarn.js from npm#439
aduh95 merged 21 commits into
nodejs:mainfrom
zhyupe:fix/yarn-berry-hash

Conversation

@zhyupe

@zhyupezhyupe commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Added bin property to NpmRegistrySpec. When installing yarn berry from custom registry, it'll only install the bin file and calculate hash of the bin file itself.

Fix#435

@aduh95

aduh95 commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Have you considered using filter option of tar.x?

aduh95
aduh95 reviewed Mar 25, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
aduh95
aduh95 reviewed Mar 25, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
aduh95
aduh95 reviewed Mar 25, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
zhyupeand others added 4 commits March 26, 2024 11:01
@zhyupe@aduh95
Update sources/corepackUtils.ts
6425697
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@zhyupe@aduh95
Update sources/corepackUtils.ts
4df5b50
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@zhyupe
chore: rename rename to renameSafe
4aff3ab
@zhyupe
chore: lint
6c15452
aduh95
aduh95 reviewed Mar 26, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
arcanis
arcanis reviewed Mar 26, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
@zhyupe@arcanis
Update sources/corepackUtils.ts
926d590
Co-authored-by: Maël Nison <nison.mael@gmail.com>
aduh95
aduh95 reviewed Mar 26, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
aduh95
aduh95 reviewed Mar 26, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
@zhyupe@aduh95
Apply suggestions from code review
cb6fdaf
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
aduh95 reviewed Mar 26, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
aduh95
aduh95 reviewed Mar 26, 2024
View reviewed changes
Comment threadsources/corepackUtils.ts Outdated
@aduh95

aduh95 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

Other than tests, is there something else to be done before this can be marked as ready for reviews?

@aduh95aduh95 mentioned this pull request Mar 26, 2024
Closed
@zhyupe

zhyupe commented Mar 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Other than tests, is there something else to be done before this can be marked as ready for reviews?

No, I think. But I'm experiencing some networking problems and have little time resolving it. So may be it will be ready in 1-2 days.

@zhyupe
zhyupe marked this pull request as ready for review March 26, 2024 16:31
@zhyupe@aduh95
Update sources/corepackUtils.ts
6c6b8aa
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
aduh95 reviewed Mar 27, 2024
View reviewed changes
Comment threadtests/main.test.ts Outdated
zhyupeand others added 3 commits March 28, 2024 00:06
@zhyupe

zhyupe commented Mar 29, 2024

Copy link
Copy Markdown
ContributorAuthor

@aduh95 Waiting for #445 being merged or the tests would fail

@aduh95
aduh95 merged commit 4672162 into nodejs:mainApr 1, 2024
@github-actionsgithub-actionsBot mentioned this pull request Apr 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arcanisarcanisarcanis left review comments
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hash validation failed for yarn when COREPACK_NPM_REGISTRY is set on one side

3 participants

@zhyupe@aduh95@arcanis