feat: add limited support for `devEngines` by aduh95 · Pull Request #643 · nodejs/corepack

aduh95 · 2025-02-08T18:40:33Z

This implementation of devEngines support in this PR is limited to packageManager only, only one packageManager can be specified, ~~the onFail field is ignored~~ EDIT: I've added support for the onFail field, supporting the same values as npm.

Fixes: #567

Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>

styfle · 2025-02-09T23:01:53Z

the onFail field is ignored

What value of onFail is used by default if its not accepting user input? download?

styfle

How about updating the readme?

In particular, mentioning the onFail behavior and also which takes precedence when both packageManager and devEngines is defined?

styfle · 2025-02-25T17:23:34Z

+- if set to `warn` or some other value, Corepack will print a warning in case
+ of mismatch.
+
+If the top-level `packageManager` field is missing, Corepack will use the


This should be the first sentence of this section.
Because it sounds like this devEngines.packageManager is ignored when there is a top level packageManager, right?

No it's never ignored. As said in the first paragraph of this section, if it is defined to something Corepack recognises, it will throw/warn/do nothing (depending of the value of onFail) if the user is trying to use an incompatible package manager (i.e. if the one defined in package.json#packageManager does not match the one defined in package.json#devEngines.packageManager for when the user is using a Corepack shim)

styfle · 2025-02-25T17:28:32Z


 Unlike `corepack use` this command doesn't take a package manager name nor a
 version range, as it will always select the latest available version from the
+range specified in `devEngines.packageManager.version`, or fallback to the


What about top-level packageManager?

That's what or fallback to the same major line is for

It's a [standardization effort by the OpenJS Foundation](https://github.com/openjs-foundation/package-metadata-interoperability-collab-space/blob/43e31689ae1fff8c46b617548655a3f60e0c9387/devengines-field-proposal.md) and has been implemented in [NPM 10.9.0](npm/cli#7766) and [Corepack 0.32.0](nodejs/corepack#643).

* Support `devEngines` field in `package.json` It's a [standardization effort by the OpenJS Foundation](https://github.com/openjs-foundation/package-metadata-interoperability-collab-space/blob/43e31689ae1fff8c46b617548655a3f60e0c9387/devengines-field-proposal.md) and has been implemented in [NPM 10.9.0](npm/cli#7766) and [Corepack 0.32.0](nodejs/corepack#643). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

susnux · 2025-07-27T15:00:03Z

+ onFail: selection.data.devEngines.packageManager.onFail,
+ },
 // Lazy-loading it so we do not throw errors on commands that do not need valid spec.
 getSpec: () => parseSpec(rawPmSpec, path.relative(initialCwd, selection.manifestPath)),


devEngines allow to specify version ranges - this now causes this to throw an exception if you pass a version like ^10.
IMHO here the enforceExactVersion option of parseSpec needs to be set to false if devEngines is used.

susnux · 2025-07-27T20:15:40Z

+ });
+});
+
+describe(`should accept range in devEngines only if a specific version is provided`, () => {


This behavior breaks existing projects which only define a range in devEngines (e.g. to make developers all use same major line of the package manager).
Normally that would be somewhat ok as its only your project and you know what you are doing, but this affects a lot of different tools like dependabot that are now broken for projects that not use corepack themself.

feat: add limited support for devEngines
b36c7f0

GeoffreyBooth reviewed Feb 8, 2025
View reviewed changes

Comment threadsources/specUtils.ts Outdated
Comment threadsources/specUtils.ts Outdated
Comment threadtests/main.test.ts
Comment threadsources/specUtils.ts Outdated
Comment threadtests/main.test.ts

Update error message
073440e
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>

aduh95 added 4 commits February 10, 2025 11:55

change throw into warn
e9f6adf

increase coverage and improve error path
6754521

Merge branch 'main' into dev-engines-part1
b25cc77

fix test when version is a URL
32cca55

arcanis approved these changes Feb 14, 2025
View reviewed changes

styfle reviewed Feb 15, 2025
View reviewed changes

aduh95 added 6 commits February 15, 2025 19:38

add limited support for onFail
8a53d7d

docs
21f9fec

Merge branch 'main'
a86f6d3

doc what happens when only devEngines is defined
54be297

fix tests
bf09e9a

increase coverage
b5c28a8

aduh95 requested a review from styfle February 15, 2025 19:04

GeoffreyBooth approved these changes Feb 23, 2025
View reviewed changes

styfle reviewed Feb 25, 2025
View reviewed changes

Comment threadsources/specUtils.ts

clarify return value is pm
8994e0a

styfle approved these changes Feb 25, 2025
View reviewed changes

aduh95 commented Feb 26, 2025
View reviewed changes

Comment threadsources/commands/Base.ts Outdated

Update error message
81419f3

MikeMcC399 reviewed Feb 26, 2025
View reviewed changes

Comment threadsources/commands/Base.ts Outdated

Update sources/commands/Base.ts
b6e8a4f

MikeMcC399 reviewed Feb 26, 2025
View reviewed changes

Comment threadsources/commands/Base.ts Outdated

MikeMcC399 mentioned this pull request Feb 26, 2025
fix: replace explicit with specify as verb #665
Merged

Merge branch 'main' into dev-engines-part1
c982089

aduh95 added 2 commits February 26, 2025 19:23

Add more tests for corepack up and corepack use
e28e3c0

validate range in corepack use
573b688

This comment was marked as resolved.
Sign in to view

aduh95 added 3 commits February 28, 2025 19:21

Merge branch 'main' into dev-engines-part1
a952550

fixup
32407e7

fixup
f761471

aduh95 merged commit b456268 into nodejs:mainFeb 28, 2025

aduh95 deleted the dev-engines-part1 branch February 28, 2025 19:06

github-actionsBot mentioned this pull request Feb 28, 2025
chore(main): release 0.32.0 #641
Merged

This was referenced Feb 28, 2025
feat: let .corepack.env be a lock file #668
Open
feat: add limited support for devEngines and .corepack.env#634
Closed

haoqunjiang mentioned this pull request Mar 13, 2025
Support devEngines field in package.jsonSchemaStore/schemastore#4561
Merged

legobeat mentioned this pull request Mar 13, 2025
Removes npm from the possible options #670
Closed

This was referenced Mar 14, 2025
[Feature]: Switch back to corepack and yarn aws/aws-sdk-js-codemod#976
Closed
[Feature] Alternative to Node.js experimental corepack to manage package manager version yarnpkg/berry#6443
Closed
What is required to ensure continued development of corepack? #681
Closed

merdopo66 approved these changes Apr 28, 2025
View reviewed changes

mrazauskas mentioned this pull request Jun 8, 2025
Add support for the devEngines field volta-cli/volta#2050
Closed

susnux reviewed Jul 27, 2025
View reviewed changes

michkot mentioned this pull request Dec 12, 2025
Asymmetry between searching for closest package.json when packageManager is defined vs when devEngines.packageManager is defined after #643 #779
Open

zbrydon mentioned this pull request May 20, 2026
Consider moving to devEnginesseek-oss/skuba#2431
Open

Uh oh!

Uh oh!

Conversation

aduh95 commented Feb 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

styfle commented Feb 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

styfle left a comment

Choose a reason for hiding this comment

Uh oh!

styfleFeb 25, 2025

Choose a reason for hiding this comment

Uh oh!

aduh95Feb 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

styfleFeb 25, 2025

Choose a reason for hiding this comment

Uh oh!

aduh95Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

susnuxJul 27, 2025

Choose a reason for hiding this comment

Uh oh!

susnuxJul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aduh95 commented Feb 8, 2025•
edited
Loading

styfle commented Feb 9, 2025•
edited
Loading

aduh95Feb 25, 2025•
edited
Loading