Skip to content

feat(regexp): stricter regexps - #449

Merged
avivkeller merged 2 commits into
mainfrom
stricter-regexps
Oct 5, 2025
Merged

feat(regexp): stricter regexps#449
avivkeller merged 2 commits into
mainfrom
stricter-regexps

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Fixes: #378
Companion: nodejs/node#60087

Makes the RegExp's more strict by removing all optional pieces.

CopilotAI review requested due to automatic review settings October 1, 2025 16:38
@avivkeller
avivkeller requested a review from a team as a code ownerOctober 1, 2025 16:38
@vercel

vercelBot commented Oct 1, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewUpdated (UTC)
api-docs-toolingReadyReadyPreviewOct 1, 2025 4:41pm

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes regular expressions stricter by removing optional backticks and text patterns, addressing issue #378 and complementing a Node.js PR. The changes ensure that API documentation headings must include specific formatting requirements that were previously optional.

Key changes:

  • Removes optional backticks from all regex patterns to require strict backtick formatting
  • Simplifies event regex to require single quotes only
  • Removes optional "Constructor:" and "Class property:" prefixes from their respective patterns

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment threadsrc/utils/parser/constants.mjs Outdated
@codecov

codecovBot commented Oct 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.55%. Comparing base (a4149a4) to head (497099d).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #449 +/- ##
==========================================
- Coverage 74.56% 74.55% -0.02% 
==========================================
Files 107 107 Lines 10459 10453 -6 Branches 681 681 ==========================================
- Hits 7799 7793 -6 
Misses 2658 2658 Partials 2 2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller
avivkeller merged commit 40e9256 into mainOct 5, 2025
19 checks passed
@avivkeller
avivkeller deleted the stricter-regexps branch October 5, 2025 13:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stricter RegExps

4 participants

@avivkeller@flakey5@AugustinMauroy