Skip to content

Explain the npm verbosity in the node image - #113

Merged
retrohacker merged 1 commit into
nodejs:masterfrom
Starefossen:docs/npm-verbose-output
Jul 29, 2016
Merged

Explain the npm verbosity in the node image#113
retrohacker merged 1 commit into
nodejs:masterfrom
Starefossen:docs/npm-verbose-output

Conversation

@Starefossen

@StarefossenStarefossen commented Mar 4, 2016

Copy link
Copy Markdown
Member

Attempts to explain the rationale behind the NPM_CONFIG_LOGLEVEL.

Close: #57
Related: nodejs/docker-iojs#36

Signed-off-by: Hans Kristian Flaatten hans.kristian.flaatten@dnt.no

@Starefossen
Starefossenforce-pushed the docs/npm-verbose-output branch from 540ee32 to f8c7511CompareMarch 4, 2016 08:41
@pesho

pesho commented Mar 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

@chorrell

chorrell commented Mar 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

chorrell
chorrell reviewed Mar 4, 2016
View reviewed changes
Comment threadREADME.md Outdated

## Verbosity

By default Node.js Docker Image has NPM log verbosity set to `verbose` instead

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@chorrell

chorrell commented Mar 4, 2016

Copy link
Copy Markdown
Contributor

One small nit, but other-wise looks good

retrohacker
retrohacker reviewed Mar 5, 2016
View reviewed changes
Comment threadREADME.md Outdated
By default Node.js Docker Image has NPM log verbosity set to `verbose` instead
of the default `warn`. This is because of the way Docker is isolated from the
host operating system and you are not guaranteed to be able to retrieve the
`npm-debug.log` file when something breaks.

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@retrohacker

retrohacker commented Mar 5, 2016

Copy link
Copy Markdown
Contributor

I think the technical sections are 🔥

I think we need to explain the rationale behind the decision in terms newcomers to both Docker and Node will understand while striking a balance with being technically correct.

@chorrellchorrell mentioned this pull request May 24, 2016
Closed
@Starefossen
Starefossenforce-pushed the docs/npm-verbose-output branch 3 times, most recently from 31203ab to 87bf354CompareJune 24, 2016 12:14
@Starefossen

Starefossen commented Jun 24, 2016

Copy link
Copy Markdown
MemberAuthor

I have incorporated the feedback and added a section to explain the rationale behind the decision of changing the verbosity level of npm. Feel free to nitpick 😄

Hans Kristian Flaatten
Explain the npm log verbosity in the Node.JS Docker Image
95a5dd9
Close: nodejs#57
Related: nodejs/docker-iojs#36
Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
@Starefossen
Starefossenforce-pushed the docs/npm-verbose-output branch from 87bf354 to 95a5dd9CompareJune 24, 2016 12:17
@chorrell

chorrell commented Jun 24, 2016

Copy link
Copy Markdown
Contributor

LGTM!

@StarefossenStarefossen mentioned this pull request Jun 26, 2016
Closed
@retrohacker

retrohacker commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

Merging this as it's gone 5 months without objection

@retrohacker
retrohacker merged commit 614e8e7 into nodejs:masterJul 29, 2016
@StarefossenStarefossen mentioned this pull request May 31, 2017
Merged
tianon pushed a commit to docker-library/official-images that referenced this pull request May 31, 2017
Hans Kristian Flaatten
Upgrade Node to 8.0.0
34aeba6
PR-URL #2997
Related: nodejs/node#12220nodejs/docker-node#411nodejs/docker-node#412nodejs/docker-node#113
Signed-off-by: Hans Kristian Flaatten <hans@starefossen.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Starefossen@pesho@chorrell@retrohacker@yosifkit