Merge pull request #1209 from PeterDaveHello/update-node.js by PeterDaveHello · Pull Request #1209 · nodejs/docker-node

PeterDaveHello · 2020-02-06T05:50:30Z

Except v13 for Alpine Linux

See:

nschonni

Looks like a few of the unofficial Alpine builds didn't finish yet, or it the missing shas issue still being tracked on the nodejs/build repo

nschonni · 2020-02-06T05:57:39Z

 x86_64) \
 ARCH='x64' \
- CHECKSUM="4c153345a08d2eeb40dfbb62f1ef6ade7ec369630f9cf9f061bf9d52b10acafc" \
+ CHECKSUM="" \


Looks like this didn't finish yet

Yeah I forgot to use "WIP" PR, I'll use PR title to indicate that.

nschonni · 2020-02-06T05:57:47Z

 x86_64) \
 ARCH='x64' \
- CHECKSUM="4c153345a08d2eeb40dfbb62f1ef6ade7ec369630f9cf9f061bf9d52b10acafc" \
+ CHECKSUM="" \


Also missing

PeterDaveHello · 2020-02-06T06:29:01Z

@rvagg is there any chance we can help speed to the unofficial build for Alpine Linux?

rvagg · 2020-02-06T07:58:44Z

build failed, the release went out unsigned nodejs/node#31657 (no SHASUMS.txt.asc)

PeterDaveHello · 2020-02-06T08:04:46Z

Didn't notice that, thanks!

dominykas · 2020-02-06T10:24:56Z

Is only v13.8.0 affected? Would it make sense to skip it in this PR, and have a separate PR for it, possibly making sure that 10.x/12.x are available faster for people to use?

PeterDaveHello · 2020-02-06T10:29:40Z

Is only v13.8.0 affected? Would it make sense to skip it in this PR, and have a separate PR for it, possibly making sure that 10.x/12.x are available faster for people to use?

Yes, and it's only Alpine Linux build, it's possible to ship the other versions and the other builds first, @nodejs/docker what do you think?

SimenB · 2020-02-06T10:37:27Z

It's not the alpine build, 13.8.0 is missing for all variants (https://nodejs.org/dist/v13.8.0/SHASUMS256.txt.asc) which is why CI is failing. v10 and v12 works for all distros.

So rolling back the updates to node 13 and keeping 10 and 12 makes sense to me. Those are the LTS versions anyways, which hopefully is what most people are running in production

BethGriggs · 2020-02-06T11:50:30Z

Ah sorry, the SHASUMS for v13.8.0 should now be available

SimenB · 2020-02-06T12:34:14Z

Thanks @BethGriggs! @rvagg does that mean the alpine versions of v13 will be available soon?

vogsphar · 2020-02-06T14:48:37Z

https://nodejs.org/dist/v13.8.0/SHASUMS256.txt.asc is there

PeterDaveHello · 2020-02-06T14:49:05Z

It's not the alpine build, 13.8.0 is missing for all variants (nodejs.org/dist/v13.8.0/SHASUMS256.txt.asc) which is why CI is failing. v10 and v12 works for all distros.
So rolling back the updates to node 13 and keeping 10 and 12 makes sense to me. Those are the LTS versions anyways, which hopefully is what most people are running in production

Oh I mean the "unofficial" build, sorry for the confusing.

SimenB · 2020-02-06T15:00:21Z

At the time of your comment, "official" builds for v13 was also broken.

Now though those should be fixed, so if you rollback v13 for alpine and force push to trigger new CI, we should be good to go

SimenB

perfect! 👍

PeterDaveHello · 2020-02-06T15:09:56Z

Let's see ;)

PeterDaveHello · 2020-02-06T17:26:09Z

v13 unofficial build has arrived!

djmitche · 2020-02-06T18:49:20Z

Fixes #2010.

SimenB · 2020-02-06T19:39:51Z

CI is unhappy...

Unable to connect to security-cdn.debian.org:http: Fetched 13.8 MB in 30s (453 kB/s) E: Failed to fetch http://security-cdn.debian.org/debian-security/pool/updates/main/c/cyrus-sasl2/libsasl2-modules-db_2.1.27+dfsg-1+deb10u1_amd64.deb

I've restarted the two failing builds

SimenB · 2020-02-06T19:46:44Z

That fixed CI, but Alpine v13 are still wrong. Those need to be reverted

v10.18.1 -> v10.19.0, v12.14.1 -> v12.15.0, v13.7.0 -> v13.8.0 See: - https://nodejs.org/en/blog/release/v10.19.0 - https://nodejs.org/en/blog/release/v12.15.0 - https://nodejs.org/en/blog/release/v13.8.0

SimenB · 2020-02-06T20:06:25Z

I did so now and pushed. I'll merge if CI is happy

nodejs-github-bot · 2020-02-06T22:50:13Z

Created PR to the official-images repo (docker-library/official-images#7429). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

SimenB · 2020-02-06T22:53:31Z

Node 13 are missing their updates for alpine as https://unofficial-builds.nodejs.org/download/release/v13.8.0/SHASUMS256.txt is not available at this time

rvagg · 2020-02-07T02:15:13Z

https://unofficial-builds.nodejs.org/download/release/v13.8.0/ available now

v13 update for Alpine Linux was missing due to the delay of unofficial build for Alpine.

PeterDaveHello · 2020-02-07T03:55:08Z

I did so now and pushed. I'll merge if CI is happy

Thanks! It'll be even better if the commit message was also revise to record the changes next time ;)

PeterDaveHello · 2020-02-07T03:56:04Z

Node.js v13 for Alpine was sent here: #1212 🎉

PeterDaveHello requested a review from a teamFebruary 6, 2020 05:51

nschonni requested changes Feb 6, 2020
View reviewed changes

PeterDaveHello changed the title ~~Update Node.js 10, 12, 13 for 2020-01 security updates~~[WIP] Update Node.js 10, 12, 13 for 2020-01 security updatesFeb 6, 2020

BethGriggs closed this Feb 6, 2020

BethGriggs reopened this Feb 6, 2020

PeterDaveHello force-pushed the update-node.js branch from 5a52fd0 to 9d02541Compare February 6, 2020 15:06

SimenB approved these changes Feb 6, 2020
View reviewed changes

PeterDaveHello changed the title ~~[WIP] Update Node.js 10, 12, 13 for 2020-01 security updates~~Update Node.js 10, 12, 13 for 2020-01 security updates (Except v13 for Alpine)Feb 6, 2020

PeterDaveHello changed the title ~~Update Node.js 10, 12, 13 for 2020-01 security updates (Except v13 for Alpine)~~Update Node.js 10, 12, 13 for 2020-01 security updatesFeb 6, 2020

PeterDaveHello force-pushed the update-node.js branch from 9d02541 to a0ebd1dCompare February 6, 2020 17:27

djmitche mentioned this pull request Feb 6, 2020
Docker image v12.15.0 #1210
Closed

SimenB mentioned this pull request Feb 6, 2020
Update Node.js v10.19.0, v12.15.0, v13.8.0 (security) #1211
Closed

Update Node.js 10, 12, 13 for 2020-01 security updates
46f5203
v10.18.1 -> v10.19.0, v12.14.1 -> v12.15.0, v13.7.0 -> v13.8.0 See: - https://nodejs.org/en/blog/release/v10.19.0 - https://nodejs.org/en/blog/release/v12.15.0 - https://nodejs.org/en/blog/release/v13.8.0

SimenB force-pushed the update-node.js branch from a0ebd1d to 46f5203Compare February 6, 2020 20:05

SimenB changed the title ~~Update Node.js 10, 12, 13 for 2020-01 security updates~~Merge pull request #1209 from PeterDaveHello/update-node.jsFeb 6, 2020

SimenB merged commit d143677 into nodejs:masterFeb 6, 2020

nodejs-github-bot mentioned this pull request Feb 6, 2020
Node: Update Node.js 10, 12, 13 for 2020-01 security updates docker-library/official-images#7429
Merged

PeterDaveHello deleted the update-node.js branch February 7, 2020 03:49

PeterDaveHello added a commit to PeterDaveHello/docker-node that referenced this pull request Feb 7, 2020
Add Node.js v13.8.0 unofficial build checksum for Alpine, ccnodejs#1209
d8cbaa1

PeterDaveHello added a commit to PeterDaveHello/docker-node that referenced this pull request Feb 7, 2020
Update Node.js v13 for Alpine to v13.8.0, ccnodejs#1209
5a27a54
v13 update for Alpine Linux was missing due to the delay of unofficial build for Alpine.

PeterDaveHello mentioned this pull request Feb 7, 2020
Update Node.js v13 for Alpine to v13.8.0 #1212
Merged

sam-github mentioned this pull request Feb 7, 2020
doc: update security release process nodejs/node#31679
Closed
2 tasks

Uh oh!

Conversation

PeterDaveHello commented Feb 6, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nschonni left a comment

Choose a reason for hiding this comment

Uh oh!

nschonniFeb 6, 2020

Choose a reason for hiding this comment

Uh oh!

PeterDaveHelloFeb 6, 2020

Choose a reason for hiding this comment

Uh oh!

nschonniFeb 6, 2020

Choose a reason for hiding this comment

Uh oh!

PeterDaveHello commented Feb 6, 2020

Uh oh!

rvagg commented Feb 6, 2020

Uh oh!

PeterDaveHello commented Feb 6, 2020

Uh oh!

dominykas commented Feb 6, 2020

Uh oh!

PeterDaveHello commented Feb 6, 2020

Uh oh!

SimenB commented Feb 6, 2020

Uh oh!

BethGriggs commented Feb 6, 2020

Uh oh!

SimenB commented Feb 6, 2020

Uh oh!

vogsphar commented Feb 6, 2020

Uh oh!

PeterDaveHello commented Feb 6, 2020

Uh oh!

SimenB commented Feb 6, 2020

Uh oh!

SimenB left a comment

Choose a reason for hiding this comment

Uh oh!

PeterDaveHello commented Feb 6, 2020

Uh oh!

PeterDaveHello commented Feb 6, 2020

Uh oh!

djmitche commented Feb 6, 2020

Uh oh!

SimenB commented Feb 6, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB commented Feb 6, 2020

Uh oh!

SimenB commented Feb 6, 2020

Uh oh!

nodejs-github-bot commented Feb 6, 2020

Uh oh!

SimenB commented Feb 6, 2020

Uh oh!

rvagg commented Feb 7, 2020

Uh oh!

PeterDaveHello commented Feb 7, 2020

Uh oh!

PeterDaveHello commented Feb 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

PeterDaveHello commented Feb 6, 2020•
edited
Loading

SimenB commented Feb 6, 2020•
edited
Loading