Skip to content

Added Issue and PR Templates - #1364

Merged
PeterDaveHello merged 1 commit into
nodejs:masterfrom
sudiptog81:dev-sudiptog81
Nov 11, 2020
Merged

Added Issue and PR Templates#1364
PeterDaveHello merged 1 commit into
nodejs:masterfrom
sudiptog81:dev-sudiptog81

Conversation

@sudiptog81

@sudiptog81sudiptog81 commented Oct 8, 2020•
edited by PeterDaveHello
Loading

Copy link
Copy Markdown
Contributor

Added ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md in .github.

Closes#1214.
Closes#1346.

PeterDaveHello
PeterDaveHello reviewed Oct 10, 2020
View reviewed changes

@PeterDaveHelloPeterDaveHello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the final newline char was missing!

https://github.com/nodejs/docker-node/pull/1364/checks?check_run_id=1227442199

@PeterDaveHello

PeterDaveHello commented Oct 10, 2020

Copy link
Copy Markdown
Member

@sudiptog81 thanks for the contribution!

The current issue template in this pull request looks like a bug report template, do you think you can also add a feature request template, as not all the issues are bug related?

I think we can do it by putting them in the folder:
https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/manually-creating-a-single-issue-template-for-your-repository

@sudiptog81

sudiptog81 commented Oct 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Sure. I will address the comments in my next commit.

@sudiptog81sudiptog81 mentioned this pull request Oct 10, 2020
Closed
nschonni
nschonni reviewed Oct 10, 2020
View reviewed changes

@nschonninschonni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking pretty good, just some minor suggestions that could also come later

Comment thread.github/ISSUE_TEMPLATE/1-bug-report.md Outdated
Comment thread.github/ISSUE_TEMPLATE/config.yml
Comment thread.github/ISSUE_TEMPLATE/config.yml
@PeterDaveHello

PeterDaveHello commented Oct 12, 2020

Copy link
Copy Markdown
Member

Nice work @sudiptog81 👍 Please give us a while to review it 😄

@PeterDaveHello
PeterDaveHello requested a review from a teamOctober 12, 2020 02:17
PeterDaveHello
PeterDaveHello approved these changes Nov 9, 2020
View reviewed changes

@PeterDaveHelloPeterDaveHello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PeterDaveHello
PeterDaveHello requested a review from a teamNovember 9, 2020 08:38
@PeterDaveHello

PeterDaveHello commented Nov 9, 2020

Copy link
Copy Markdown
Member

Ask for one more approval from @nodejs/docker 😃

@PeterDaveHello

PeterDaveHello commented Nov 9, 2020

Copy link
Copy Markdown
Member

@sudiptog81 would you squash these commits and rebase your branch base on the latest master branch? I can also help you do it if you want.

@sudiptog81

sudiptog81 commented Nov 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@sudiptog81 would you squash these commits and rebase your branch base on the latest master branch? I can also help you do it if you want.

I'll do that as soon as able. Thanks for the approval!

@PeterDaveHello
PeterDaveHello merged commit 554638e into nodejs:masterNov 11, 2020
@PeterDaveHello

PeterDaveHello commented Nov 11, 2020

Copy link
Copy Markdown
Member

Let's get it merged, and we'll see if there is anything we can improve in the usage.

@PeterDaveHello

PeterDaveHello commented Nov 11, 2020

Copy link
Copy Markdown
Member

Awesome

image

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterDaveHelloPeterDaveHelloPeterDaveHello approved these changes
@nschonninschonniAwaiting requested review from nschonni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create GitHub Pull Request Templates Create GitHub Issue Templates

3 participants

@sudiptog81@PeterDaveHello@nschonni