Replace obsolete ENV VAR VALUE with ENV VAR=VALUE

[orgads]

Description

Fixes these warnings:

- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format

Testing Details

Build passed.

Types of changes

• Documentation
• Version change (Update, remove or add more Node.js versions)
• Variant change (Update, remove or add more variants, or versions of variants)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Other (none of the above)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING.md document.
• All new and existing tests passed.

[PeterDaveHello]

Need to fix update.sh & functions.sh

[PeterDaveHello]

Why should this one depend on #2258?

Fixed. This PR now depends on:

• chore: Simplify yarn and alpine version update #2258

The failing test is because https://news.ycombinator.com is down. I reported it, hope they'll fix it soon.

[orgads]

Why should this one depend on #2258?

Because they touch the same line in update.sh.

[PeterDaveHello]

That's something should be prevented.

I don't want to mix different topic in the same pull request.

Why should this one depend on #2258?

Because they touch the same line in update.sh.

[orgads]

I agree. So which one of them do you want to accept first? You can either merge the other one and then I'll rebase this one, or I can swap them.

[PeterDaveHello]

Please remove unrelated commit changes that are not relevant to the topic.

[PeterDaveHello]

I agree. So which one of them do you want to accept first? You can either merge the other one and then I'll rebase this one, or I can swap them.

Maybe this one as it was sent earlier.

[orgads]

Done

[orgads]

Rebased. Please review.

[SimenB]

Needs another rebase, but LGTM 👍

[nschonni]

As @tianon mentions in #2252 (comment), this advice might not actually be great

[orgads]

Rebased. As for the warnings, whether we like them or not - they currently appear on every build, and it is annoying. It doesn't look like it's going to change anytime soon.

So we can either ignore them and hope that upstream docker will remove them, or change to the new syntax.

[nschonni]

Totally agree, they are annoying, and I'm OK if one of the other member wants to dismiss my block. I want to make sure there is visibility that there is a disagreement on these warnings internal to the Docker groups.
I haven't looked to see if it is possible to suppress them either.

[orgads]

Rebased.

[SimenB]

Yeah, I think we should land this. While I totally understand the reason one would be against the deprecation, it has landed and these warnings are really annoying as it pollutes every PR 😅

@orgads would you be up for a final rebase here, and we can land it? (there's also a v25 now)

[orgads]

Sure, done.

I didn't change any link, so the failing test looks unrelated to my changes.

[SimenB]

Both links work, so that seems fine 🙂 We can merge this after docker-library/official-images#20099 lands to not make that diff so noisy.

Thanks!

I'm OK if one of the other member wants to dismiss my block

[github-actions]

Created PR on the official-images repo (docker-library/official-images#20105). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

[SimenB]

Thanks for your patience, @orgads 😀