Uh oh!
There was an error while loading. Please reload this page.
Update latest versions for security release - #783
Conversation
nodejs-github-bot
commented
Jun 13, 2018
@mhdawson sadly an error occured when I tried to trigger a build :( |
mhdawson
commented
Jun 13, 2018
Had talked to @SimenB earlier in context of security release going to manually land. |
nschonni
commented
Jun 13, 2018
Might want to use the update.sh since it will also fix the Yarn version too |
mhdawson
commented
Jun 13, 2018
@nschonni I was specifically asked to exclude that as its a security release |
Sorry, I can't but I sent @LaurentGoderre a text to see if he's around |
mhdawson
commented
Jun 13, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
LaurentGoderre
commented
Jun 13, 2018
I aporoved them but i was wondering why not use the update script? The images would get a bump in alpine version and yarn version as well. Is the rationale that we don't want anything else in the release? |
mhdawson
commented
Jun 13, 2018
@LaurentGoderre yes, I had asked @SimenB and he confirmed that the docker team asks that we only update the node.js versions in a security release so that there is as small a delta as possible. I used the update script to generate and removed the non-node updates. |
LaurentGoderre
commented
Jun 13, 2018
Ok great! |
LaurentGoderre
commented
Jun 13, 2018
Only waiting on the alpine builds |
SimenB
commented
Jun 13, 2018
Yup! 😀 Awesome that it got released as soon as possible.
Yup, says so in their readme: https://github.com/docker-library/official-images/blob/master/README.md#security-releases |
LaurentGoderre
commented
Jun 13, 2018
The change detection failed :( https://travis-ci.org/nodejs/docker-node/jobs/391532321#L432 |
SimenB
commented
Jun 13, 2018
It was probably merged to docker hub before the build finished on master? They merged 20 minutes after this PR was merged |
LaurentGoderre
commented
Jun 13, 2018
OOOOOOOh!!! I didn't think of that!!! |
LaurentGoderre
commented
Jun 13, 2018
I have a lead on how to make this even easier! |
Thanks for building great images! I hope it's not off-topic but I tried to find when yarn is updated (1.7 in this case)? It looks like it's supposed to be updated together with node UPDATE: I'll guess it's not part of security upgrades, regarding to #784? |

No description provided.