Fixed new shfmt issue

[LaurentGoderre]

No description provided.

[LaurentGoderre]

ARG!!! shfmt and shellcheck are conflicting now....

[chorrell]

Can we pin to a version of the shfmt image? I'd like to not be surprised by these kinds of changes in the future.

[LaurentGoderre]

Had to find a syntax that pleased both validator and the regexp syntax.....

[LaurentGoderre]

@chorrell the source repo doesn't seem to use versions or tags for their docker image

[LaurentGoderre]

@chorrell can we merge since it passed all the tests?

[chorrell]

Can we use the sha256 hash?

$ docker inspect --format='{{.RepoDigests}}' jamesmstone/shfmt [jamesmstone/shfmt@sha256:4eff05b54e87c11e8214848de3e5f4bb47a4241b99ac5c6554db5cc164015810]

[chorrell]

This should work:

- docker run -it --rm -v "$(pwd)":/sh -w /sh jamesmstone/shfmt@sha256:4eff05b54e87c11e8214848de3e5f4bb47a4241b99ac5c6554db5cc164015810 -i 2 -l -w -ci .

I would really like to see this incorporated. The last thing we want is for some random change to shfmt (and in the scheme of things, trivial bash syntax issues) to hold up future releases.

[LaurentGoderre]

Good point!

[LaurentGoderre]

Done!

[LaurentGoderre]

All tests are green, can we merge?

[chorrell]

Something for another pr maybe: One of the secure variables in your .travis.yml has an invalid format

[LaurentGoderre]

Not sure that is true though, the variable actually work....

[chorrell]

¯\_(ツ)_/¯

[LaurentGoderre]

We can look into it though