Skip to content
This repository was archived by the owner on Mar 25, 2018. It is now read-only.

update style guide - #79

Merged
stevemao merged 1 commit into
nodejs:masterfrom
a0viedo:style-guide-updates
Feb 12, 2016
Merged

update style guide#79
stevemao merged 1 commit into
nodejs:masterfrom
a0viedo:style-guide-updates

Conversation

@a0viedo

Copy link
Copy Markdown
Member

This is a work in progress. I would love any feedback.

Additions:

@a0viedoa0viedo mentioned this pull request Feb 8, 2016
@chrisdickinson

Copy link
Copy Markdown
Contributor

This LGTM so far!

Comment threadSTYLE-GUIDE.md Outdated
is necessary, include it as an asset in `assets/code-examples` and link to
it.
* When using underscores, asterisks and backticks please use proper escaping (**\\\_**, **\\\*** and **\\\`** instead of **\_**, **\*** and **\`**)
* References to constructor functions should start with upper-case letters

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PascalCase?

@a0viedo

Copy link
Copy Markdown
MemberAuthor

Updated with @stevemao's comments.

stevemao added a commit that referenced this pull request Feb 12, 2016
@stevemao
stevemao merged commit 42aaec4 into nodejs:masterFeb 12, 2016
@a0viedo
a0viedo deleted the style-guide-updates branch February 12, 2016 12:08
@Knighton910

Copy link
Copy Markdown

LGTM

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@a0viedo@chrisdickinson@Knighton910@stevemao