esm: experimental wasm modules

[MylesBorins]

This is a first pass at a loader for wasm modules.

It offers support for both named imports as well as deafult.
It may be possible to move some of this logic down to C++, but
I think the current implementation might be good enough. It doesn't
currently use the ESM cache, but AFAICT it isn't currently exposed.

Will dig in more with tests / examples / cache after initial
implementation gets feedback.

/cc @linclark@lukewagner@tschneidereit@sunfishcode

[devsnek]

related: nodejs/node#18972

i think we should wait for wasm modules to be specified, at which point v8 would provide them for us.

[MylesBorins]

@devsnek I had a meeting with some of the folks working on the WASM team today. I don't think it is clear how much of this will be in ecma262 / V8 vs. blink

Since this is related to the loader there way not actually be as much as expected inside of V8 proper. I also think it might be worth exploring this as an experimental interface to get an implementation of the expected behavior into the hands of developers, this in turn could affect the standard being developed.

i'll let the folks I cc'd chime in about timing and implementation thoughts

[guybedford]

@MylesBorins I think named exports are important to include here, as that is how the WASM spec integration with ES modules will work (//cc @littledan).

If you are looking for the code to do identifier validation, I included this in 9377b27#diff-e866c1b8fc8510c620d56a7c4b841885R133 for the CommonJS named exports PR. I think that would be a worthy addition and important inclusion for merging this.

[littledan]

Hey, I'm working on standards-track Wasm/ESM integration at https://github.com/WebAssembly/esm-integration/tree/master/proposals/esm-integration . I hope we can work out semantics here that match the proposed standard. I don't have any planned changes to semantics, but over the next few days I'll be trying to clean up the explainer and spec text to be more clear and well-layered with other changes.

[littledan]

This change from @devsnek LGTM, but there is more work to do.

[guybedford]

I've pushed up a commit to support the exact import semantics here now. Because the v8 module system can only link Module objects that are SourceTextModule objects, we need to create one to handle this, just like we do for dynamic modules.

Should be good to go now, and thanks all for review.

Issues resolved.

[guybedford]

Yes Web Assembly modules dont have live bindings, instead features like mutable global are captured through a static binding interface.

…

On Tue, 07 May 2019 at 09:12, Wesley Wigham ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/internal/modules/esm/create_wasm_module.js <#46 (comment)> : > +${[...importModules].map((module) => { + const specifierStr = JSON.stringify(module); + const importNames = new Set( + imports + .filter(({ module: m }) => m === module) + .map(({ name }) => name) + ); + const impts = + [...importNames].map((name) => `${name} as $${name}`).join(', '); + const defs = [...importNames].map((name) => `${name}: $${name}`).join(', '); + return `import { ${impts} } from ${specifierStr}; + imports[${specifierStr}] = { ${defs} };`; + }).join('\n')} +const { exports } = new WebAssembly.Instance(import.meta.module, imports); +${WebAssembly.Module.exports(module) + .map(({ name }) => `export const ${name} = exports.${name};`).join('\n')} A facade like this means that there won't be live bindings for the wasm module, no? Are wasm exports supposed to be live bound? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAESFSR7HIRBNIA3HR4MATDPUETUZANCNFSM4G2XCCQQ> .

[ljharb]

That can’t provide live bindings, or they can’t consume them?

[guybedford]

@ljharb Web Assembly modules neither import or export live bindings.

[littledan]

What @guybedford says about WebAssembly modules matches the proposal which you can find in more detail at https://github.com/webassembly/esm-integration .

[devsnek]

modulo my comment and assuming this works, it looks pretty good!

[littledan]

The logic in translators.js makes sense to me, but I don't understand enough of the context to do a proper review.

It'd be good to have more tests here. We've gone through various iterations on semantics in this code review, so it'd be good to have tests for some of those scenarios, for example.

cc @Ms2ger

[guybedford]

Upstream PR created at nodejs/node#27659.