Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 16, 2020. It is now read-only.
CI fixes for latest commits and reland #45 - #49
Merged
Conversation
ContributorAuthor
MylesBorins
commented
Mar 5, 2019
Contributor
Some failures...
|
GeoffreyBooth
approved these changes
Mar 5, 2019
MylesBorins
commented
Mar 5, 2019
Contributor
We've ended up reverted #45 temporarily and moving it into this PR in an attempt to get CI green. We should like land as a single commit after we get it working |
Contributor
CI of modules-lkgr for comparison: https://ci.nodejs.org/job/node-test-commit/26377/ |
MylesBorins
commented
Mar 5, 2019
Contributor
hmmm I'm actually seeing a bunch more failures on LKGR before that other Pr... fun! I'm going to go ahead and land this as it is @guybedford lets dig into and try to find the windows fix independently and worry about making the branch release ready later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up some linting issues that crept in on the last merges.