Skip to content

Use GitHub Status API - #15

Merged
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:github-status-api
Apr 10, 2016
Merged

Use GitHub Status API#15
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:github-status-api

Conversation

@Fishrock123

@Fishrock123Fishrock123 commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

Here's a test of a success status, and a failure status.

cc @williamkapke & @phillipj

Fishrock123
Fishrock123 reviewed Apr 8, 2016
View reviewed changes
Comment threadlib/pollTravis.js Outdated
repo: options.repoName,
sha: options.lastSha,
target_url: `https://travis-ci.org/${options.owner}/${options.repoName}/builds/${travisId}`,
context: "Travis CI via nodejs-github-bot",

This comment was marked as off-topic.

Sign in to view

@Fishrock123

Fishrock123 commented Apr 8, 2016

Copy link
Copy Markdown
ContributorAuthor

Fixes: #14

@Fishrock123
Fishrock123force-pushed the github-status-api branch 2 times, most recently from 7be5ef6 to dd117b5CompareApril 8, 2016 22:59
@Fishrock123

Fishrock123 commented Apr 8, 2016

Copy link
Copy Markdown
ContributorAuthor

rebased

@williamkapke

williamkapke commented Apr 9, 2016

Copy link
Copy Markdown
Contributor

LGTM

@phillipj

phillipj commented Apr 9, 2016

Copy link
Copy Markdown
Member

You mentioned on IRC that we should be polling SHA for all repos. Any reason you haven't deleted pollByPrThenComment()?

IIRC this means we would do status updates for readable-stream, but still do comments on nodejs.org and citgm.

@phillipj

phillipj commented Apr 9, 2016

Copy link
Copy Markdown
Member

Have you tested updates on PRs and how that affects previously set statuses? Could we end up with misleading success status on a PR if the first build succeeded, but new commits/pushed rebase results in brokens builds?

@Fishrock123

Fishrock123 commented Apr 9, 2016

Copy link
Copy Markdown
ContributorAuthor

@phillipj I left that because I wasn't sure if it was still necessary.

Afaik statuses tie to commits, so if the commits are updated GitHub automatically resets it.

@Fishrock123

Fishrock123 commented Apr 9, 2016

Copy link
Copy Markdown
ContributorAuthor

I'll give it a test when I get home later though.

phillipj
phillipj reviewed Apr 9, 2016
View reviewed changes
Comment threadlib/pollTravis.js Outdated
return createGhStatus('failure', lastBuildForCommit.id, 'build failure')
} else if (~['created', 'started'].indexOf(lastState)) {
console.log(`* ${prInfo} "${lastState}" build found, will do check #${checkNumber + 1} in 30 seconds`)
if (checkNumber === 1) {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@Fishrock123

Fishrock123 commented Apr 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Hmmm, looks like this no-longer works after being rebased on #8. Investigating.

@Fishrock123

Fishrock123 commented Apr 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Got it working. My bad.

Looks like this doesn't actually handle PR updates, working on it. (Example: TestOrgPleaseIgnore/test-github-bot#17)

@Fishrock123

Fishrock123 commented Apr 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Updated, now works for PR updates: TestOrgPleaseIgnore/test-github-bot#17

@Fishrock123
Fishrock123 merged commit 8e255d3 into nodejs:masterApr 10, 2016
@Fishrock123

Fishrock123 commented Apr 10, 2016

Copy link
Copy Markdown
ContributorAuthor

going to open a new PR for some of the other bits

Fishrock123 added a commit to Fishrock123/github-bot that referenced this pull request Apr 10, 2016
@Fishrock123
Remove outdated travis commenting logic
a6c5b36
Discussion in nodejs#15
@Fishrock123Fishrock123 mentioned this pull request Apr 10, 2016
Merged
@phillipjphillipj mentioned this pull request Apr 10, 2016
Closed
@Fishrock123Fishrock123 mentioned this pull request Apr 10, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fishrock123@williamkapke@phillipj