Uh oh!
There was an error while loading. Please reload this page.
Added doc, benchmark and deps/X node core PR labels - #32
Conversation
phillipj
commented
Apr 27, 2016
I'm merging this as no objections has been raised. |
williamkapke
commented
Apr 27, 2016
post LGTM! ;) |
phillipj
commented
Apr 27, 2016
@williamkapke thanks! 😄 |
| // order of entries in this map *does* matter for the resolved labels | ||
| const subSystemLabelsMap = { | ||
| // don't want to label it a c++ update when we're "only" bumping the Node.js version | ||
| 'c++': /^src\/(?!node_version\.h)/, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fishrock123
commented
Apr 27, 2016
belated LGTM. I'll try to find time to tackle some of the more complex ones soon |
Fishrock123
commented
Apr 27, 2016
nodejs/node#6432 Seems to have been labeled as |
Fishrock123
commented
Apr 27, 2016
Hmm, seems like this doesn't only label |
phillipj
commented
Apr 28, 2016
Woops, cause the old @Fishrock123 goodie! I'll be ready to deploy as soon as you've got a fix ready. |
This improves the current node core auto PR labelling functionality by supporting these extra labels:
docfor exclusivedoc/*changesbenchmarkfor exclusivebenchmark/*changesv8,libuv,openssletc when having changes indeps/X/*Also ignores changes to
src/node_version.hto avoid labelling that asc++as mentioned in #31 (comment).@jbergstroem@mscdex@Fishrock123 does these labels sound reasonable to you?
Refs #31, nodejs/node#6247