Skip to content

labels: add version labels - #55

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:add-version-labels
Closed

labels: add version labels#55
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:add-version-labels

Conversation

@mscdex

@mscdexmscdex commented Jul 24, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@mscdex

mscdex commented Jul 24, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I wasn't sure exactly how to test the webhook, but going by the github webhook docs that should be the correct property for obtaining the base branch from the webhook event data.

@phillipj

phillipj commented Jul 25, 2016

Copy link
Copy Markdown
Member

I wasn't sure exactly how to test the webhook ...

Np, no one else has gotten around creating automated tests for webhooks so far - hopefully some day :) The easiest way to test webhooks locally ATM would be via SSE relay functionality.

@williamkapke could you add the necessary relay webhook to https://github.com/TestOrgPleaseIgnore/node?

@jbergstroem

jbergstroem commented Aug 5, 2016

Copy link
Copy Markdown
Member

Perhaps just mock the api response from the version we're talking to?

@phillipj

phillipj commented Aug 5, 2016

Copy link
Copy Markdown
Member

Yeah, I've got a branch ready to push soon which mocks every call made to GH

@jbergstroem

jbergstroem commented Aug 5, 2016

Copy link
Copy Markdown
Member

Awesome!

@phillipjphillipj mentioned this pull request Aug 5, 2016
Merged
Fishrock123
Fishrock123 reviewed Sep 5, 2016
View reviewed changes
Comment threadlib/node-labels.js
: matchAllSubSystem(filepathsChanged, limitLib)

// Add version labels if PR is made against a version branch
const m = /^(v\d+\.(?:\d+|x))(?:-|$)/.exec(baseBranch)

This comment was marked as off-topic.

Sign in to view

@phillipj

phillipj commented Sep 5, 2016

Copy link
Copy Markdown
Member

Landed in 3a30e94

So sorry for stalling this for so long @mscdex! Included an integration test ensuring the v6.x got added when the webhook payload said the PR targeted v6.x-staging.

@phillipjphillipj closed this Sep 5, 2016
@phillipj

phillipj commented Sep 5, 2016

Copy link
Copy Markdown
Member

This is now live in production

@Fishrock123

Fishrock123 commented Sep 5, 2016

Copy link
Copy Markdown
Contributor

Comment was ignored? :/

@phillipj

phillipj commented Sep 5, 2016

Copy link
Copy Markdown
Member

Comment was ignored? :/

@Fishrock123 sry, didn't see your comment! I'll get a PR up right away... Was this a coincident you having a look at this old & stalled PR, and me working to get it merged??

phillipj added a commit to phillipj/github-bot that referenced this pull request Sep 5, 2016
@phillipj
labels: stricter version match in base branch
dfde4cd
Minor adjustment to the regex matching the base branch a PR is targeted against.
Refs nodejs#55 (comment)
@phillipjphillipj mentioned this pull request Sep 5, 2016
Merged
@mscdex

mscdex commented Sep 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Hooray, it works!: nodejs/node#8437

@phillipj

phillipj commented Sep 8, 2016

Copy link
Copy Markdown
Member

Yiiiiiha, nice work!

@mscdex you got any objections to this
#70?

On Thursday, 8 September 2016, Brian White notifications@github.com wrote:

Hooray, it works!: nodejs/node#8437
nodejs/node#8437

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#55 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABLLE53ggEMENBcRs0lHpzM6S0OVjNAeks5qn0JwgaJpZM4JTqBN
.

@mscdex
mscdex deleted the add-version-labels branch September 12, 2016 05:20
phillipj added a commit that referenced this pull request Oct 18, 2016
@phillipj
labels: stricter version match in base branch (#70)
f9b6cb1
Minor adjustment to the regex matching the base branch a PR is targeted against.
Refs #55 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mscdex@phillipj@jbergstroem@Fishrock123