chore(main): release gyp-next 0.17.0 - #232

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
release-please--branches--main--components--gyp-next
Closed

chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom
release-please--branches--main--components--gyp-next

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Mar 11, 2024•
edited by cclauss
Loading

Copy link
Copy Markdown
Contributor

🤖 I have created a release beepboop

0.17.0 (2024-03-11)

⚠ BREAKING CHANGES

  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.

gyp

Features

  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)

Bug Fixes

  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)

Documentation

  • README.md: Add pipx installation and run instructions (#165) (4d28b15)

This PR was generated with Release Please. See documentation.

targos
targos reviewed Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)

@targostargosMar 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.

@targostargosMar 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys

cclauss
cclauss requested changes Mar 11, 2024
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!

@lukekarrys

lukekarrys commented Mar 11, 2024•
edited
Loading

Copy link
Copy Markdown
Member

It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.

I will also add a config to fix the tag names.

@lukekarryslukekarrys mentioned this pull request Mar 11, 2024
Merged
@targostargos closed this Mar 12, 2024
@targos
targos deleted the release-please--branches--main--components--gyp-next branch March 12, 2024 07:44
@targos

targos commented Mar 12, 2024•
edited by cclauss
Loading

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
+1 more reviewer
@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(main): release gyp-next 0.17.0 - #232
Closed
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Closed
chore(main): release gyp-next 0.17.0#232
github-actions[bot] wants to merge 1 commit into
mainfrom 
release-please--branches--main--components--gyp-next
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Mar 11, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Contributor
🤖 I have created a release beepboop
0.17.0 (2024-03-11)
⚠ BREAKING CHANGES
  • Remove support for Python 2
  • msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.
gyp
Features
  • Add command line argument for gyp --version (#164) (5c9f4d0)
  • add PRODUCT_DIR_ABS variable (#151) (80d2626)
  • Add proper support for IBM i (#140) (fdda4a3)
  • add VCToolsVersion for msvs (#209) (0e35ab8)
  • hoist shared libs to PRODUCT_DIR for all platforms (1248a9d)
  • msvs: add SpectreMitigation attribute (#190) (853e464)
  • msvs: add support for Visual Studio 2022 (#124) (4bd9215)
  • ninja build for iOS (#174) (b6f2714)
  • port "add support for MSVC cross-compilation" from node (72ea11b)
  • support building shared libraries on z/OS (#137) (293bcfa)
  • support source files with duplicate basename (#62) (72eddfe)
  • use LDFLAGS_host for host toolset (#98) (bea5c7b)
  • xcode: --cross-compiling overrides arch-specific settings (973bae0)
  • zos: support IBM Open XL C/C++ & PL/I compilers on z/OS (#178) (43a7211)
Bug Fixes
  • .S is an extension for asm file on Windows (#115) (d2fad44)
  • add python 3.6 to node-gyp integration test (3462d4c)
  • add quotes for command in msvs generator (#217) (d3b7bcd)
  • add support of utf8 encoding (#105) (4d0f93c)
  • align flake8 test (#122) (f1faa8d)
  • avoid quoting cflag name and parameter with space separator (#223) (2b9703d)
  • build failure with ninja and Python 3 on Windows (#113) (c172d10)
  • cmake on python 3 (fd61f5f)
  • compile_commands.json generation (#22) (afa06c4)
  • do not rewrite absolute paths to avoid long paths (#74) (c2ccc1a)
  • execvp: printf: Argument list too long (#147) (c4e14f3)
  • flake8 extended-ignore (#186) (c38493c)
  • lock windows env (#163) (44bd0dd)
  • make: only generate makefile for multiple toolsets if requested (#133) (f463a77)
  • move configuration information into pyproject.toml (#176) (d69d8ec)
  • msvs.py: remove overindentation (#102) (3f83e99)
  • msvs: avoid fixing path for arguments with "=" (#143) (7e8f16e)
  • msvs: correctly rename object files for absolute paths (#71) (f2c7618)
  • msvs: do not fix paths in action command arguments (fc22f83)
  • msvs: fix paths again in action command arguments (#121) (7159dfb)
  • No build_type in default_variables (#183) (ac262fe)
  • node.js debugger adds stderr (but exit code is 0) -> shouldn't throw (#179) (1a457d9)
  • only include MARMASM when toolset is target (5a2794a)
  • port ab4aca868d from upstream (#11) (6f4834e)
  • py lint (3b6a8ee)
  • revert for windows compatibility (d078e7d)
  • revert posix build job (#86) (39dc34f)
  • some Python lint issues (#200) (d2dfe4e)
  • support msvs_quote_cmd in ninja generator (#117) (46486ac)
  • update gyp.el to change case to cl-case (#93) (13d5b66)
  • update shebang lines from python to python3 (#94) (a1b0d41)
  • upstream 50317c3 from nodejs/node (1db1392)
  • use generator_output as output_dir (#191) (35ffeb1)
  • xcode cmake parsing (eefe8d1)
Documentation
  • README.md: Add pipx installation and run instructions (#165) (4d28b15)
This PR was generated with Release Please. See documentation.
targos
targos
reviewed
Mar 11, 2024
View reviewed changes
Comment threadCHANGELOG.md
@@ -1,5 +1,78 @@
# Changelog

## [0.17.0](https://github.com/nodejs/gyp-next/compare/gyp-next-v0.16.2...gyp-next-v0.17.0) (2024-03-11)
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something's wrong in the config. Tags shouldn't include the package's name.
@targostargosMar 11, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lukekarrys
cclauss
cclauss
requested changes
Mar 11, 2024
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Python 2 was dropped in https://github.com/nodejs/gyp-next/releases/tag/v0.8.0 so I do not think we should highlight that in the release!
@lukekarrys
lukekarrys
commented
Mar 11, 2024•

edited

Loading

Copy link


Copy Markdown

Member
It looks like it didn't correctly find the most recent release. I will make a new PR that uses the last-release-sha config to make that explicit. I'll note in the PR that this config can be removed anytime after the next release PR is merged.
I will also add a config to fix the tag names.
@lukekarryslukekarrys
mentioned this pull request
Mar 11, 2024
 Merged

@targostargos
closed this
Mar 12, 2024
@targos
targos
deleted the

release-please--branches--main--components--gyp-next

branch
March 12, 2024 07:44
@targos
targos
commented
Mar 12, 2024•

edited by cclauss

Loading

Copy link


Copy Markdown

Member
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@targostargostargos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@targos@cclauss