Make sure that INCS_* vars are properly escaped

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?

[Jayman2000]

The main motivation behind this pull request is to make gyp-next do the right thing, even if the path to the project that you’re building contains spaces. See the commit message for details.

How to test this pull request

1. Make sure that you have all of the prerequisites for building Node.js with Ninja. (I’ve been able to put Node.js into a directory that contains spaces and build it with Ninja. I haven’t been able to do the same without Ninja yet.)

2. Make sure that you have Wget installed.

3. Make sure that you have a clone of the node repository, and that the path to the clone of your Node.js repo contains spaces.

4. Change directory into your node repository.

5. Make sure that you are on the node repository’s main branch by running this command:

   git switch main
   

6. Try to build and test Node.js by running these commands:

   ./configure --debug --ninja
   make
   make test-only
   

   The final make test-only command will fail to build.

7. Download this pull request as a patch by running this command:

   wget https://patch-diff.githubusercontent.com/raw/nodejs/gyp-next/pull/280.patch
   

8. Apply this patch to the vendored dependency that’s in the node repo by running this command:

   git am --directory=deps/npm/node_modules/node-gyp/gyp 280.patch
   

9. Delete the patch file by running this command:

   rm 280.patch
   

10. Try to build and test Node.js by running these commands:

    ./configure --debug --ninja
    make
    make test-only
    

    At this point, the final make test-only command will successfully build, but (for me at least) one or more of the actual tests will fail once it’s run.

There’s almost certainly a better way to test out this pull request, but this is the best that I can come up with given the fact that I don’t really know anything about Node.js or gyp-next. If anyone can come up with a better or easier way to test out this pull request, then that would be helpful.

[cclauss]

Please rebase so we can ensure our tests pass.

Can we add a test that fails without this change but passes with it?