Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Generic method - #145

Closed
emberian wants to merge 11 commits into
nodejs:masterfrom
emberian:generic_method
Closed

Generic method#145
emberian wants to merge 11 commits into
nodejs:masterfrom
emberian:generic_method

Conversation

@emberian

@emberianemberian commented Dec 16, 2012

Copy link
Copy Markdown
Contributor

Should close up #92 and pave the way for nodejs/node-v0.x-archive#3192. Currently depends on #144 or #106 being merged, because I wasn't paying attention and I don't know how to rebase it. Tests pass, but I'm still not confident in the patch quality. Review desired.

@emberian

emberian commented Dec 19, 2012

Copy link
Copy Markdown
ContributorAuthor

I'm having some trouble fixing this one. The parser runs out of data before it actually finds anything invalid. At http_parser.c:1819, the default behaviour seems to be to assume that the request was valid. Mind taking a peek?

@emberian

emberian commented Dec 20, 2012

Copy link
Copy Markdown
ContributorAuthor

I think adding a bit to http_parser indicating whether, given the current state, the request/response is valid if parsing were to stop immediately is a good solution. Any thoughts before I code it up later today?

kolbyjack
kolbyjack reviewed Dec 20, 2012
View reviewed changes
Comment threadhttp_parser.c Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@emberian
Add generic method test
7d7852d
Reverted a simple test to succeed even though the result is invalid, because
there are other more important things that need doing in this patch (like
getting it to actually work)
@emberian
More proper HTTP_BOTH handling
ff4d643
@emberian
Don't break on long generic method names
6d5f231
@jamesamcl

jamesamcl commented Aug 20, 2013

Copy link
Copy Markdown

Any update on accepting this? I really need support for custom methods but I'd rather not use a fork.

@emberian

emberian commented Aug 20, 2013

Copy link
Copy Markdown
ContributorAuthor

@udp The patch still doesn't quite work iirc. Want me to pick it back up?

@jamesamcl

jamesamcl commented Aug 20, 2013

Copy link
Copy Markdown

That'd be great if you could. I don't mind doing some testing.

@emberian

emberian commented Aug 20, 2013

Copy link
Copy Markdown
ContributorAuthor

alright, I'll get to it later today.

On Tue, Aug 20, 2013 at 6:40 AM, James McLaughlin
notifications@github.comwrote:

That'd be great if you could. I don't mind doing some testing.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/145#issuecomment-22936106
.

@jamesamcljamesamcl mentioned this pull request Aug 21, 2013
Closed
@mikedeboer

mikedeboer commented Jun 11, 2014

Copy link
Copy Markdown

@cmr to achieve full-spec CalDAV support for our project, mikedeboer/jsDAV, this'd be awesome to have!

I'm guessing more and more ppl will stumble upon this sooner or later, but you'll be my hero to start with ;)

@emberian

emberian commented Jun 11, 2014

Copy link
Copy Markdown
ContributorAuthor

I'm no longer interested in working on this. Sorry!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emberian@jamesamcl@mikedeboer@kolbyjack@bnoordhuis