Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Nov 6, 2022. It is now read-only.
parser: returning 2 from on_headers_complete - #299
Closed
indutny wants to merge 1 commit into
Closed
Conversation
Returning `2` from on_headers_complete will tell parser that it should not expect neither a body nor any futher responses on this connection. This is useful for handling responses to a CONNECT request which may not contain `Upgrade` or `Connection: upgrade` headers. See: nodejs/node#6198
4 tasks
Contributor
LGTM if tests pass. Do we have the ability to do this in CI yet? |
indutny
commented
Apr 16, 2016
MemberAuthor
@mscdex thank you, this is semver minor, right? |
mscdex
commented
Apr 16, 2016
Contributor
Assuming the original intention was for |
indutny
commented
Apr 16, 2016
MemberAuthor
Yeah, also existing code will work just as it was before. |
indutny
commented
Apr 16, 2016
MemberAuthor
A question for @nodejs/lts team, do you think this could be backported to v4.x.x? It seems that responses to CONNECT requests are currently a bit broken in LTS |
indutny
commented
Apr 16, 2016
MemberAuthor
The problem is that this is a semver-minor change in http-parser. |
indutny
commented
Apr 19, 2016
MemberAuthor
Alright, enough time to collect feedback. Landing. |
indutny added a commit
that referenced
this pull request
Apr 19, 2016
Returning `2` from on_headers_complete will tell parser that it should not expect neither a body nor any futher responses on this connection. This is useful for handling responses to a CONNECT request which may not contain `Upgrade` or `Connection: upgrade` headers. See: nodejs/node#6198 PR-URL: #299 Reviewed-By: Brian White <mscdex@mscdex.net>
indutny
commented
Apr 19, 2016
MemberAuthor
Landed in 04d28a7, thank you everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning
2from on_headers_complete will tell parser that itshould not expect neither a body nor any futher responses on
this connection. This is useful for handling responses to a
CONNECT request which may not contain
UpgradeorConnection: upgradeheaders.See: nodejs/node#6198
cc @bnoordhuis@jasnell@mscdex
See also: nodejs/node#6198 (comment)